From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/signal06: fix test for regression with earlier version of gcc and kernel
Date: Thu, 9 Feb 2017 17:19:22 +0100 [thread overview]
Message-ID: <20170209161922.GA25369@rei> (raw)
In-Reply-To: <1479284063-12968-1-git-send-email-fenggw-fnst@cn.fujitsu.com>
Hi!
> 1. Currently, following code is incorrect on some releases with
> earlier version of gcc(tested on RHEL5.11GA):
>
> while (D == d && loop < LOOPS) {
>
> Because the argument in function test(double d) is used via (%rsp),
> but here we actually need a xmm register to trigger the fpu bug.
> So use global value instead to make sure to take use of xmm.
>
> 2. Although this regression test is designed to trigger SIGSEGV
> intentionally, on some releases with old kernel(tested on RHEL5.11GA),
> this will still lead to segmentation fault that terminate the program
> and break the test even though compiling with -O2. So slightly adjust
> the weight of the codes in child thread to depress SIGSEGV trigger's
> chance while increase LOOPS to ensure reproducible.
This needs to be worded a bit better, I had to read the email discussion
to remember what we are trying to avoid here.
Something as:
2. Although this regresssion test is designed to trigger SIGSEGV
intentionally in order to invoke signal handler, producing it too
fast can lead to a program termination on older kernels (found in
RHEL5.11GA). Hence we divide the frequency in half and increase
number of LOOPS at the same time as a compensation to make sure
that the bug is 100% reproducible.
OK to commit with this change to the patch description?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-02-09 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 6:58 [LTP] [PATCH] syscalls/signal06: fix test for regression with earlier version of gcc and kernel Guangwen Feng
2016-08-08 8:44 ` Li Wang
2016-08-16 3:08 ` Guangwen Feng
2016-09-20 9:59 ` Guangwen Feng
2016-10-05 13:43 ` Cyril Hrubis
2016-10-06 10:31 ` Guangwen Feng
2016-10-06 11:15 ` Cyril Hrubis
2016-10-10 7:05 ` Guangwen Feng
2016-10-10 13:15 ` Cyril Hrubis
2016-10-11 7:17 ` Guangwen Feng
2016-11-16 8:14 ` [LTP] [PATCH v2] " Guangwen Feng
2017-02-09 9:00 ` Guangwen Feng
2017-02-09 16:19 ` Cyril Hrubis [this message]
2017-02-13 3:38 ` Guangwen Feng
2017-02-13 9:12 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209161922.GA25369@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox