[LTP] [PATCH] mmap16: extend checkpoint wait time during fs fill

Jan Stancek
2017-02-13T13:33:52Z

----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Monday, 13 February, 2017 11:02:34 AM
> Subject: Re: [LTP] [PATCH] mmap16: extend checkpoint wait time during fs fill
>
> Hi!
> > +
> > + /* Give parent enough time to consume FS free blocks */
> > + if (tst_checkpoint_wait(0, 60*1000))
> > + tst_brkm(TBROK | TERRNO, cleanup,
> > + "wait for parent to fill entire space");
>
> Hrm, I wonder why I hardcoded the timeout into the library. It would be
> much better if we could have used the safe variant here.
>
> What about we add TST_SAFE_CHECKPOINT_WAIT2() that would take a timeout
> parameter. Pretty much the same as we do for WAKE2 that takes a number
> of processes to wake as a paramter.

Fine by me. Can you push it?
I can rebase & push patch using new TST_SAFE_CHECKPOINT_WAIT2().

Regards,
Jan