public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] lib/tst_tmpdir.c: fix compilation with older kernels
@ 2017-02-14  3:09 Xiao Yang
  2017-02-14  9:31 ` Cyril Hrubis
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao Yang @ 2017-02-14  3:09 UTC (permalink / raw)
  To: ltp

Compilation fails because of undefined __USE_GNU on RHEL5.11GA.
So we need to define _GNU_SOURCE to make __USE_GNU defined.

This has been broken by commmit:

commit fc0c72a85a9de6a846587855c3c40394a6782616
Author: Cyril Hrubis <chrubis@suse.cz>
Date:   Mon Feb 13 15:35:09 2017 +0100

	lib: Move rmobj() to tst_tmpdir.c

Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
 lib/tst_tmpdir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/tst_tmpdir.c b/lib/tst_tmpdir.c
index 71ca3b9..405d377 100644
--- a/lib/tst_tmpdir.c
+++ b/lib/tst_tmpdir.c
@@ -56,7 +56,7 @@
  *		Neither tst_tmpdir() or tst_rmdir() has a return value.
  *
  *********************************************************/
-
+#define _GNU_SOURCE
 #include <sys/mman.h>
 #include <sys/types.h>
 #include <sys/stat.h>
-- 
1.8.3.1




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [LTP] [PATCH] lib/tst_tmpdir.c: fix compilation with older kernels
  2017-02-14  3:09 [LTP] [PATCH] lib/tst_tmpdir.c: fix compilation with older kernels Xiao Yang
@ 2017-02-14  9:31 ` Cyril Hrubis
  0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2017-02-14  9:31 UTC (permalink / raw)
  To: ltp

Hi!
> Compilation fails because of undefined __USE_GNU on RHEL5.11GA.
> So we need to define _GNU_SOURCE to make __USE_GNU defined.

Good catch. I've updated the changelog, since the problem is about older
libc not kernel and pushed along with a few more typo fixed I've done
yesterday.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-14  9:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-14  3:09 [LTP] [PATCH] lib/tst_tmpdir.c: fix compilation with older kernels Xiao Yang
2017-02-14  9:31 ` Cyril Hrubis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox