[LTP] [PATCH 1/1] rpc: Add missing header

[LTP] [PATCH 1/1] rpc: Add missing header

[Petr Vorel]

This fixes: implicit declaration of function ‘pmap_unset’.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/network/rpc/basic_tests/rpc01/rpc_server.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/network/rpc/basic_tests/rpc01/rpc_server.c b/testcases/network/rpc/basic_tests/rpc01/rpc_server.c
index db5865f94..6bf219607 100644
--- a/testcases/network/rpc/basic_tests/rpc01/rpc_server.c
+++ b/testcases/network/rpc/basic_tests/rpc01/rpc_server.c
@@ -6,6 +6,7 @@
 #include <stdlib.h>
 #include <unistd.h>
 #include <rpc/rpc.h>
+#include <rpc/pmap_clnt.h>
 #include "librpc01.h"
 
 int debug = 0;
-- 
2.12.0

[LTP] [PATCH 1/1] rpc: Add missing header

[Cyril Hrubis]

Hi!
> This fixes: implicit declaration of function ???pmap_unset???.

Hmm, the man 3 rpc only states that <rpc/rpc.h> needs to be included,
what distro this fails on?

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH 1/1] rpc: Add missing header

[Petr Vorel]

Hi Cyril!

> > This fixes: implicit declaration of function ???pmap_unset???.

> Hmm, the man 3 rpc only states that <rpc/rpc.h> needs to be included,
> what distro this fails on?

Various distros. Tested on these:
* Debian testing/unstable (with recent updates)
$ lsb_release -a
Distributor ID:	Debian
Description:	Debian GNU/Linux 9.0 (stretch)
Release:	9.0
Codename:	stretch

$ gcc --version
gcc (Debian 6.3.0-8) 6.3.0 20170221

* Debian stretch cross compilation to sparc64
$ sparc64-linux-gnu-gcc --version
sparc64-linux-gnu-gcc (Debian 6.3.0-9) 6.3.0 20170316

* openSUSE Tumbleweed (with recent updates)
$ lsb_release -a
LSB Version:	n/a
Distributor ID:	openSUSE
Description:	openSUSE Tumbleweed
Release:	20170311
Codename:	n/a

$ gcc --version
gcc (SUSE Linux) 6.3.1 20170202 [gcc-6-branch revision 245119]

Error is:
rpc_server.c: In function ‘main’:
rpc_server.c:78:2: warning: implicit declaration of function ‘pmap_unset’ [-Wimplicit-function-declaration]
  pmap_unset(program, version);

But maybe I'm wrong, doing some mistake.

Kind regards,
Petr

[LTP] [PATCH 1/1] rpc: Add missing header

[Cyril Hrubis]

Hi!
> > Hmm, the man 3 rpc only states that <rpc/rpc.h> needs to be included,
> > what distro this fails on?
> Error is:
> rpc_server.c: In function ???main???:
> rpc_server.c:78:2: warning: implicit declaration of function ???pmap_unset??? [-Wimplicit-function-declaration]
>   pmap_unset(program, version);
> 
> But maybe I'm wrong, doing some mistake.

Looks to me like glibc bug. Since the tirpc/rpc/rpc.h includes the
rpc/pmap_clnt.h while the glibc equivalent does not. But I'm not expect
on RPC either. I guess that we should better ask on the glibc ML.

-- 
Cyril Hrubis
chrubis@suse.cz