public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/4] Test for CVE-2016-4997 on setsockopt
Date: Tue, 28 Mar 2017 10:27:40 +0200	[thread overview]
Message-ID: <20170328082740.GA1045@rei> (raw)
In-Reply-To: <20170327180812.37a590ea@linux-v3j5>

Hi!
> > > +static struct tst_test test = {
> > > +	.tid = "cve-2016-4997",
> > > +	.min_kver = "2.6.32",
> > > +	.test_all = run,
> > > +	.needs_root = 1,
> > > +};  
> > 
> > I also wonder if we should compile the test with -m32 by default, we
> > whould have to add a configure test if compilation with -m32 works
> > though.
> > 
> 
> Yes, I think that is best, but passing -m32 to the test's make target does not
> cause the LTP library to be compiled with -m32 so linking fails. I'm not sure
> how to get it to build both binaries.

Hmm, right, we would have to compile the test library for 32bit as well,
that may be tricky bussines. On the other hand there are at least two
other testcases that does not work when compiled for 64bits which would
make use of this as well.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2017-03-28  8:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 15:26 [LTP] [PATCH 2/4] Test for CVE-2016-4997 on setsockopt Richard Palethorpe
2017-03-27 15:34 ` Cyril Hrubis
2017-03-27 16:08   ` Richard Palethorpe
2017-03-28  8:27     ` Cyril Hrubis [this message]
2017-03-28  9:39     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170328082740.GA1045@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox