From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] Out-of-tree build missing some data files.
Date: Wed, 29 Mar 2017 15:31:56 +0200 [thread overview]
Message-ID: <20170329133156.GF7089@rei.lan> (raw)
In-Reply-To: <BN6PR11MB20517B46C814B90AB73E3D43CD320@BN6PR11MB2051.namprd11.prod.outlook.com>
Hi!
> Unfortunately, this doesn't seem to have had any effect. Changes were...
>
> -INSTALL_TARGETS := $(wildcard file*)
> +INSTALL_TARGETS := $(wildcard $(abs_srcdir)/*.in)
>
> -INSTALL_TARGETS := $(wildcard *.c)
> +INSTALL_TARGETS := $(wildcard $(abs_srcdir)/*.c)
Looking into the build system env_post.mk these are prefixed with
abs_srcdir automatically there so changing these to simply '*.c' or
'*.in' fixes the problem.
This patch fixes the installation for me:
(I will push it along with a few more out-of-tree build fixes)
diff --git a/testcases/commands/ar/datafiles/Makefile b/testcases/commands/ar/datafiles/Makefile
index 09dc029..ef99bca 100644
--- a/testcases/commands/ar/datafiles/Makefile
+++ b/testcases/commands/ar/datafiles/Makefile
@@ -15,5 +15,5 @@ top_srcdir ?= ../../../..
include $(top_srcdir)/include/mk/env_pre.mk
INSTALL_DIR := testcases/data/ar01
-INSTALL_TARGETS := $(wildcard file*)
+INSTALL_TARGETS := file*
include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/commands/file/datafiles/Makefile b/testcases/commands/file/datafiles/Makefile
index 6769fc6..d3cb847 100644
--- a/testcases/commands/file/datafiles/Makefile
+++ b/testcases/commands/file/datafiles/Makefile
@@ -15,5 +15,5 @@ top_srcdir ?= ../../../..
include $(top_srcdir)/include/mk/env_pre.mk
INSTALL_DIR := testcases/data/file01
-INSTALL_TARGETS := $(wildcard in*)
+INSTALL_TARGETS := in*
include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/commands/ld/datafiles/Makefile b/testcases/commands/ld/datafiles/Makefile
index 7b19207..4eb64ad 100644
--- a/testcases/commands/ld/datafiles/Makefile
+++ b/testcases/commands/ld/datafiles/Makefile
@@ -17,6 +17,6 @@ include $(top_srcdir)/include/mk/env_pre.mk
INSTALL_DIR := testcases/data/ld01
MAKE_TARGETS :=
-INSTALL_TARGETS := $(wildcard *.c)
+INSTALL_TARGETS := *.c
include $(top_srcdir)/include/mk/generic_leaf_target.mk
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-03-29 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 19:35 [LTP] Out-of-tree build missing some data files Steve East
2017-03-28 13:37 ` Cyril Hrubis
2017-03-28 18:03 ` Steve East
2017-03-29 13:31 ` Cyril Hrubis [this message]
2017-03-29 17:00 ` Steve East
2017-03-30 10:33 ` Li Wang
2017-03-30 10:59 ` Cyril Hrubis
2017-03-30 12:06 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329133156.GF7089@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox