public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Domenico Andreoli <domenico.andreoli@linux.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] open_posix_testsuite: Fix recursive build
Date: Mon, 10 Apr 2017 14:31:54 +0200	[thread overview]
Message-ID: <20170410123154.GB20255@localhost> (raw)
In-Reply-To: <20170406152448.GA4977@rei.lan>

On Thu, Apr 06, 2017 at 05:24:49PM +0200, Cyril Hrubis wrote:
> Hi!

Hallo,

> > -top_srcdir?=		.
> > +open_posix_srcdir := $(if $(top_srcdir),$(top_srcdir)/testcases/open_posix_testsuite,$(abspath .))
> 
> I wonder if we want to be consistent with the rest of the LTP
> buildsystem define the top_srcdir ?= ../.. here so that we could use
> it below in both cases when the make is executed in the open posix
> directory or from the top level Makefile.

The important part is the use of abspath somewhere, these variables
are referenced also from processes running in different subdirs.

This is quite visible in the automatically generated makefiles.

> > diff --git a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
> > index 67a60c8cb..d50d517ae 100755
> > --- a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
> > +++ b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh
> > @@ -22,7 +22,7 @@ generate_locate_test_makefile() {
> >  
> >  	echo "Generating $maketype Makefiles"
> >  
> > -	locate-test --$maketype | sed -e 's,^./,,g' > make-gen.$maketype
> > +	locate-test --$maketype $top_srcdir | sed -e 's,^./,,g' > make-gen.$maketype
> >  	generate_makefiles make-gen.$maketype $*

I had great troubles in enabling this step

Domenico

-- 
3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13

      reply	other threads:[~2017-04-10 12:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05  8:58 [LTP] [PATCH 1/2] open_posix_testsuite: Fix recursive build Petr Vorel
2017-04-05  8:58 ` [LTP] [PATCH 2/2] travis: Add out-of-tree build Petr Vorel
2017-04-06 15:24 ` [LTP] [PATCH 1/2] open_posix_testsuite: Fix recursive build Cyril Hrubis
2017-04-10 12:31   ` Domenico Andreoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170410123154.GB20255@localhost \
    --to=domenico.andreoli@linux.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox