From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] pan/ltp-pan.c: fix incorrect number of total tests
Date: Mon, 10 Apr 2017 15:50:21 +0200 [thread overview]
Message-ID: <20170410135021.GC23301@rei.lan> (raw)
In-Reply-To: <1491544700-6312-1-git-send-email-yangx.jy@cn.fujitsu.com>
Hi!
> pan/ltp-pan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pan/ltp-pan.c b/pan/ltp-pan.c
> index 1614c70..beed623 100644
> --- a/pan/ltp-pan.c
> +++ b/pan/ltp-pan.c
> @@ -645,7 +645,7 @@ int main(int argc, char **argv)
> strerror(errno));
> fprintf(logfile,
> "\n-----------------------------------------------\n");
> - fprintf(logfile, "Total Tests: %d\n", coll->cnt);
> + fprintf(logfile, "Total Tests: %d\n", (coll->cnt - starts));
This change does not make much sense to me. The coll->cnt is number of
tests loaded from the runtest file, right? The starts is basically
number of tests to be executed. The runltp script executes ltp-pan with
-S which means that starts is set to coll->cnt in the main() function
and so after this change it would print "Total Tests: 0" regardless.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-04-10 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 5:58 [LTP] [PATCH] pan/ltp-pan.c: fix incorrect number of total tests Xiao Yang
2017-04-10 13:50 ` Cyril Hrubis [this message]
2017-04-11 3:36 ` Xiao Yang
2017-04-12 15:31 ` Cyril Hrubis
2017-04-13 2:47 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410135021.GC23301@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox