From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] syscalls/quotactl02.c: add Q_XGETNEXTQUOTA flag test
Date: Tue, 11 Apr 2017 16:30:50 +0200 [thread overview]
Message-ID: <20170411143050.GA3998@rei.lan> (raw)
In-Reply-To: <1490955322-7483-1-git-send-email-yangx.jy@cn.fujitsu.com>
Hi!
> +# ifdef Q_XGETNEXTQUOTA
> + {QCMD(Q_XSETQLIM, USRQUOTA), &set_dquota, check_qlim, Q_XGETNEXTQUOTA,
> + "set and use Q_XGETNEXTQUOTA to get xfs disk quota limits"},
> +# endif
Can we, rather than this ifdef, define a fallback definition for the
flag (ideally in an header in lapi) and handle possible EINVAL as TCONF
in case that we run on an older kernel?
Otherwise it looks good.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-04-11 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 10:15 [LTP] [PATCH 1/2] syscalls/quotactl02.c: add Q_XGETNEXTQUOTA flag test Xiao Yang
2017-03-31 10:15 ` [LTP] [PATCH 2/2] syscalls/quotactl03.c: add new regression test Xiao Yang
2017-04-11 14:44 ` Cyril Hrubis
2017-04-11 14:30 ` Cyril Hrubis [this message]
2017-04-12 4:04 ` [LTP] [PATCH v2 1/2] syscalls/quotactl02.c: add Q_XGETNEXTQUOTA flag test Xiao Yang
2017-04-12 4:04 ` [LTP] [PATCH v2 2/2] syscalls/quotactl03.c: add new regression test Xiao Yang
2017-04-12 11:58 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411143050.GA3998@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox