public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] time taken by memcg_stress_test
Date: Wed, 12 Apr 2017 15:15:31 +0200	[thread overview]
Message-ID: <20170412131530.GC25790@rei> (raw)
In-Reply-To: <1491855678.3139.47.camel@cavium.com>

Hi!
> > Two hours is excessive indeed however getting right balance between
> > runtime and stress test coverage is always tricky...
> > 
> > I guess that we can settle for 15 minutes, maybe shorten the interval
> > parameter that is currently set to 10 seconds to compensate for that.
> > 
> > Also running the two test separately (two records in the runtest file
> > that would call the script with a paramter selecting between the
> > tests)
> > would make it better as well.
> 
> So would a patch that changed RUN_TIME to 15 minutes (15 * 60) and
> changed the timout value sent to run_stress from 10 to 5 be considered
> OK?

Looks reasonable to me.

> ??I can submit one if we think this is a reasonable change. ??I am
> not sure why splitting the test in two would help, LTP doesn't run any
> tests in parallel does it? ??I'd rather skip that part of the change as
> I am worried I might mess something up. ??Change 60 to 15 and 10 to 5 on
> the other hand is completely straight forward.

We can always do the split in a separate patch.

There are several reason why test should be split into resasonably small
portions. The most important is that if big long running test fails you
have no idea which part has failed and rerunning it to figure it out
takes a lot of time...

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2017-04-12 13:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 22:58 [LTP] time taken by memcg_stress_test Steve Ellcey
2017-03-24 15:58 ` Cyril Hrubis
2017-04-10 20:21   ` Steve Ellcey
2017-04-12 13:15     ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170412131530.GC25790@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox