From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC] [PATCH] tst_kvcmp: Add support for extra kernel versions
Date: Thu, 27 Apr 2017 16:52:05 +0200 [thread overview]
Message-ID: <20170427145030.GA28668@rei.lan> (raw)
In-Reply-To: <316485995.3602202.1493299267158.JavaMail.zimbra@redhat.com>
Hi!
I've pushed the original patch with added -77 to the example in the
commit message.
Now this patch should fix the missing commands:
From da7a8f38d34659f4e02631c2e0a0f49e59edfbfa Mon Sep 17 00:00:00 2001
From: Cyril Hrubis <chrubis@suse.cz>
Date: Thu, 27 Apr 2017 16:48:02 +0200
Subject: [PATCH] cpuset: Make use of tst_kvcmp
The tst_kvercmp2 was removed in:
commit 4847f1c13dabbfadd612aa812e2c99973f35f230
Author: Cyril Hrubis <chrubis@suse.cz>
Date: Mon Nov 14 13:44:45 2016 +0100
apicmd: Get rid of tst_kvercmp* binaries.
And these calls were not fixed beforehand.
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
.../cpuset/cpuset_base_ops_test/cpuset_base_ops_testset.sh | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/testcases/kernel/controllers/cpuset/cpuset_base_ops_test/cpuset_base_ops_testset.sh b/testcases/kernel/controllers/cpuset/cpuset_base_ops_test/cpuset_base_ops_testset.sh
index 63a9dc5..992b8f2 100755
--- a/testcases/kernel/controllers/cpuset/cpuset_base_ops_test/cpuset_base_ops_testset.sh
+++ b/testcases/kernel/controllers/cpuset/cpuset_base_ops_test/cpuset_base_ops_testset.sh
@@ -128,8 +128,7 @@ test_cpus()
base_op_test "$CPUSET/1/cpus" "0,1-$((nr_cpus-2))," "0-$((nr_cpus-2))"
fi
- tst_kvercmp2 3 0 0 "RHEL6:2.6.32"
- if [ $? -eq 0 ]; then
+ if tst_kvcmp -lt "3.0 RHEL6:2.6.32"; then
base_op_test "$CPUSET/1/cpus" "0-" "WRITE_ERROR"
else
base_op_test "$CPUSET/1/cpus" "0-" "0"
@@ -164,8 +163,7 @@ test_mems()
base_op_test "$CPUSET/1/mems" "0,1-$((nr_mems-2))," "0-$((nr_mems-2))"
fi
- tst_kvercmp2 3 0 0 "RHEL6:2.6.32"
- if [ $? -eq 0 ]; then
+ if tst_kvcmp -lt "3.0 RHEL6:2.6.32"; then
base_op_test "$CPUSET/1/mems" "0-" "WRITE_ERROR"
else
base_op_test "$CPUSET/1/mems" "0-" "0"
--
2.10.2
OK to commit?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-04-27 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 15:52 [LTP] [RFC] [PATCH] tst_kvcmp: Add support for extra kernel versions Cyril Hrubis
2017-04-24 7:58 ` Jan Stancek
2017-04-26 15:06 ` Cyril Hrubis
2017-04-27 8:28 ` Jan Stancek
2017-04-27 13:01 ` Cyril Hrubis
2017-04-27 13:21 ` Jan Stancek
2017-04-27 14:52 ` Cyril Hrubis [this message]
2017-04-28 6:58 ` Jan Stancek
2017-04-28 15:10 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427145030.GA28668@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox