From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC] [PATCH] syscalls/move_pages12: Two fixes.
Date: Fri, 5 May 2017 14:55:39 +0200 [thread overview]
Message-ID: <20170505125539.GC16729@rei.suse.de> (raw)
In-Reply-To: <959115821.7379621.1493924279254.JavaMail.zimbra@redhat.com>
Hi!
> > * Do not multiply free ram with 1024
> >
> > - Since we get overflow even on fairly modest
> > machine with a few GB of RAM and the test
> > will always report "Not enough RAM".
>
> This is obviously ok.
I've pushed this part.
> >
> > * Drop caches before the test
> >
> > - Otherwise the move_pages() syscalls may
> > fail with ENOMEM.
> >
>
> How about we try to allocate/touch couple MB worth of pages
> on node, we are going to move to (alloc_pages_on_node())?
> If we can't allocate, exit with TCONF.
>
> Otherwise we free those pages just before move_pages().
> Wouldn't that give us better guarantee, there are some
> free pages on target node?
Sounds reasonable, I will look into this.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2017-05-05 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 12:42 [LTP] [RFC] [PATCH] syscalls/move_pages12: Two fixes Cyril Hrubis
2017-05-04 18:57 ` Jan Stancek
2017-05-05 12:55 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505125539.GC16729@rei.suse.de \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox