public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] numa: fix memhog fails in test8
@ 2017-05-24  2:16 Li Wang
  2017-05-24 13:05 ` Cyril Hrubis
  0 siblings, 1 reply; 2+ messages in thread
From: Li Wang @ 2017-05-24  2:16 UTC (permalink / raw)
  To: ltp

memhog test fails on first iteration (when the memhog binary is not
in the page cache) because the test script runs too fast and looks
at the statistics even befor the memmhog binary has a chance to run.

In this patch, just redirectiong the output to a file and then checking
the content in the script in a loop.

Suggested-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Li Wang <liwang@redhat.com>
---
 testcases/kernel/numa/numa01.sh | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/testcases/kernel/numa/numa01.sh b/testcases/kernel/numa/numa01.sh
index 4eda3f1..e3fe854 100755
--- a/testcases/kernel/numa/numa01.sh
+++ b/testcases/kernel/numa/numa01.sh
@@ -315,9 +315,20 @@ test8()
 	# Memory will be allocated using round robin on nodes.
 	Exp_incr=$(echo "$MB / $total_nodes" |bc)
 
-	numactl --interleave=all memhog -r1000000 1MB 2>&1 >/dev/null &
+	numactl --interleave=all memhog -r1000000 1MB 2>&1 >ltp_numa_test8.log &
 	pid=$!
 
+	local retries=20
+	while [ $retries -gt 0 ]; do
+
+		if grep -m1 -q '.' ltp_numa_test8.log; then
+			break
+		fi
+
+		retries=$((retries-1))
+		tst_sleep 50ms
+	done
+
 	for node in $nodes_list; do
 		Mem_curr=$(echo "$(extract_numastat_p $pid $node) * $MB" |bc)
 
-- 
2.9.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [LTP] [PATCH] numa: fix memhog fails in test8
  2017-05-24  2:16 [LTP] [PATCH] numa: fix memhog fails in test8 Li Wang
@ 2017-05-24 13:05 ` Cyril Hrubis
  0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2017-05-24 13:05 UTC (permalink / raw)
  To: ltp

Hi!
> memhog test fails on first iteration (when the memhog binary is not
> in the page cache) because the test script runs too fast and looks
> at the statistics even befor the memmhog binary has a chance to run.
> 
> In this patch, just redirectiong the output to a file and then checking
> the content in the script in a loop.

Pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-05-24 13:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-24  2:16 [LTP] [PATCH] numa: fix memhog fails in test8 Li Wang
2017-05-24 13:05 ` Cyril Hrubis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox