public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers3@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/2] ltp: update add_key tests for nonempty NULL payload fix
Date: Mon,  5 Jun 2017 10:48:09 -0700	[thread overview]
Message-ID: <20170605174811.95267-1-ebiggers3@gmail.com> (raw)

From: Eric Biggers <ebiggers@google.com>

These two patches remove the existing add_key02 test, which is having its
behavior changed, and replaces it with the more thorough add_key03 test which
specifically tests the "NULL payload with nonzero length" case, which was
subject to a kernel bug causing a NULL dereference with some key types.

(The reason I'm not simply changing the add_key02 test is that I don't want it
to appear as a regression on old kernels.  I'm not sure exactly how this kind of
thing is typically handled in LTP, though.)

Eric Biggers (2):
  syscalls/add_key02: remove test
  syscalls/add_key03: add test for NULL payload with nonzero length

 runtest/syscalls                              |   2 +-
 testcases/kernel/syscalls/.gitignore          |   2 +-
 testcases/kernel/syscalls/add_key/add_key02.c |  74 ------------------
 testcases/kernel/syscalls/add_key/add_key03.c | 104 ++++++++++++++++++++++++++
 4 files changed, 106 insertions(+), 76 deletions(-)
 delete mode 100644 testcases/kernel/syscalls/add_key/add_key02.c
 create mode 100644 testcases/kernel/syscalls/add_key/add_key03.c

-- 
2.13.0.506.g27d5fe0cd-goog


             reply	other threads:[~2017-06-05 17:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 17:48 Eric Biggers [this message]
2017-06-05 17:48 ` [LTP] [PATCH 1/2] syscalls/add_key02: remove test Eric Biggers
2017-06-05 17:48 ` [LTP] [PATCH 2/2] syscalls/add_key03: add test for NULL payload with nonzero length Eric Biggers
2017-06-06 12:06   ` Cyril Hrubis
2017-06-06 17:06     ` Eric Biggers
2017-06-06 11:55 ` [LTP] [PATCH 0/2] ltp: update add_key tests for nonempty NULL payload fix Cyril Hrubis
2017-06-06 17:04   ` Eric Biggers
2017-06-07 13:51     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170605174811.95267-1-ebiggers3@gmail.com \
    --to=ebiggers3@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox