public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/3] syscalls/mq_timedreceive: Add check data returned from mq_timedreceive
Date: Tue, 6 Jun 2017 15:58:08 +0200	[thread overview]
Message-ID: <20170606135808.GE5208@rei> (raw)
In-Reply-To: <20170605200549.3832-1-pvorel@suse.cz>

Hi!
> +	for (j = 0; j < tc->len; j++) {
> +		if (rmsg[j] != smsg[j]) {
> +			tst_res(TFAIL | TTERRNO, "mq_timedreceive wrong data in loop %d returned %d, expected %d",

Let's keep the messages short and to the point, something as:

			tst_res(TFAIL,
				"mq_timedreceive(): wrong data %i at %u, expected %i",
				rmsg[j], j, smsg[j]);

And also we should drop the TTERRNO since it's uninitialized in this
case.


Otherwise it's fine.

-- 
Cyril Hrubis
chrubis@suse.cz

      parent reply	other threads:[~2017-06-06 13:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 20:05 [LTP] [PATCH 1/3] syscalls/mq_timedreceive: Add check data returned from mq_timedreceive Petr Vorel
2017-06-05 20:05 ` [LTP] [PATCH 2/3] syscalls/mq_timedsend: Convert to new API + cleanup Petr Vorel
2017-06-06 14:26   ` Cyril Hrubis
2017-06-05 20:05 ` [LTP] [PATCH 3/3] syscalls/mq_notify: Cleanup + use mq.h Petr Vorel
2017-06-06 13:58 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170606135808.GE5208@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox