From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] dio: reduce the number of cycles
Date: Thu, 15 Jun 2017 15:17:52 +0200 [thread overview]
Message-ID: <20170615131752.GA8212@rei.lan> (raw)
In-Reply-To: <CAEemH2ebRhRDST+HMUB=LUge_w5TvEC7PaYDwCYxaP+hGjpiyQ@mail.gmail.com>
Hi!
> >> > What's the reliability after the patch btw? What is the actual
> >> > percentage of undetected failures for at least 10 runs of the test?
> >>
> >> I ran diotest30 10 times with "-i 100" and 8 of them failed. IIRC, it
> >> was not 100% reproduced either when I first saw the test failure in
> >> 4.10-rc kernel testing. So I think ~80% probability to reproduce is
> >> fine.
> >
> > Fair enough I've added this paragraph to the commit message and pushed,
> > thanks.
>
> Hmm, it does not takes about 100 minutes, without this change, it
> takes almost 9mins. After applying, only 50secs.
>
> That's probably my description misleading you, sorry about that. Since
> you have already submitted this patch, so, let it go.
Strange, it does take about ~10 minutes after the patch is applied for
me and about ~100 before at least for diotest6, diotest3 is a bit faster
with ~20 minutes before and ~4 minutes after. That is on NUMA machine
with 24 CPUs and 16GB RAM and /tmp on Btrfs.
The diotest6 appears to be taking about ~45 minutes in our automated
framework before this patch and diotest3 takes about 3 minutes.
On my workstation the diotest3 takes ~5 minutes after the patch and
diotest06 takes ~45 minutes. That is much more modest machine with just
4GB RAM and 4 CPUs.
So I would say that the resulting time depends on many factors, most
notably the underlying I/O device, fileystem, number of CPUs and RAM.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2017-06-15 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 3:38 [LTP] [PATCH] dio: reduce the number of cycles Li Wang
2017-06-14 11:16 ` Eryu Guan
2017-06-14 13:49 ` Cyril Hrubis
2017-06-15 6:54 ` Eryu Guan
2017-06-15 9:23 ` Cyril Hrubis
2017-06-15 9:38 ` Li Wang
2017-06-15 13:17 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615131752.GA8212@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox