public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 3/3] commands/keyctl01: Check keyctl support instead of kernel version
Date: Tue, 18 Jul 2017 15:27:20 +0200	[thread overview]
Message-ID: <20170718132719.GA22620@rei.lan> (raw)
In-Reply-To: <20170718063144.18856-3-fenggw-fnst@cn.fujitsu.com>

Hi!
I've pushed the first two patches, thanks.

>  setup()
>  {
> -	if tst_kvcmp -le 2.6.33; then
> -		tst_brk TCONF "Kernel newer than 2.6.33 is needed"
> +	keyctl 2>&1 | tr '\n' ' ' | grep "request2" | grep "negate" | \
> +		grep "show" | grep "unlink" >/dev/null

Uh, what are we grepping here for exactly? Can't we do that with a
single regular expression?

> +	if [ $? -ne 0 ]; then
> +		tst_brk TCONF "keyctl operations not supported"
>  	fi
>  
>  	PATH_KEYSTAT="/proc/key-users"
> -- 
> 2.9.4
> 
> 
> 

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2017-07-18 13:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11  6:20 [LTP] [PATCH 1/3] commands/keyctl01: Fix potential infinite loop Guangwen Feng
2017-05-11  6:20 ` [LTP] [PATCH 2/3] commands/keyctl01: Fix getting key serial number Guangwen Feng
2017-07-07 13:08   ` Cyril Hrubis
2017-07-11 12:27     ` Guangwen Feng
2017-07-13 10:55       ` Guangwen Feng
2017-07-13 12:15         ` Guangwen Feng
2017-07-17 11:42           ` Cyril Hrubis
2017-07-18  6:31             ` [LTP] [PATCH v2 1/3] commands/keyctl01: Fix potential infinite loop Guangwen Feng
2017-07-18  6:31               ` [LTP] [PATCH v2 2/3] commands/keyctl01: Fix getting key serial number Guangwen Feng
2017-07-18  6:31               ` [LTP] [PATCH v2 3/3] commands/keyctl01: Check keyctl support instead of kernel version Guangwen Feng
2017-07-18 13:27                 ` Cyril Hrubis [this message]
2017-07-19  3:42                   ` Guangwen Feng
2017-07-20  5:38                     ` [LTP] [PATCH v3] " Guangwen Feng
2017-08-04 12:08                       ` Cyril Hrubis
2017-08-14 11:25                         ` [LTP] [PATCH v4] " Guangwen Feng
2017-08-23 16:23                           ` Cyril Hrubis
2017-05-11  6:20 ` [LTP] [PATCH 3/3] commands/keyctl01: Enable this test for RHEL6 Guangwen Feng
2017-07-07 13:13   ` Cyril Hrubis
2017-07-11 11:47     ` Guangwen Feng
2017-07-04  2:33 ` [LTP] [PATCH 1/3] commands/keyctl01: Fix potential infinite loop Guangwen Feng
2017-07-07 12:55 ` Cyril Hrubis
2017-07-11 11:48   ` Guangwen Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718132719.GA22620@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox