From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] syscalls/fcntl36: add tests for OFD locks
Date: Wed, 23 Aug 2017 10:40:20 +0200 [thread overview]
Message-ID: <20170823084019.GA8175@rei.lan> (raw)
In-Reply-To: <20170823041558.33vhtfsdswenhcfa@XZHOUW.usersys.redhat.com>
Hi!
> > > + if (tst_fill_file(fname, 1, write_size, thread_cnt)) {
> > > + tst_brk(TBROK, "Failed to create tst file");
> > > + }
> >
> > No need for the curly braces around single line statement here.
>
> I thought it's safer for a macro. Now it's one line function in
> the macro, not hurting to remove the braces.
Even macros that have several lines are safe in LTP since we use the
do { ... } while (0) idiom.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-08-23 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 3:14 [LTP] [PATCH] syscalls/fcntl36: add tests for OFD locks Xiong Zhou
2017-08-14 16:02 ` Cyril Hrubis
2017-08-21 11:17 ` [LTP] [PATCH v2] " Xiong Zhou
2017-08-21 16:00 ` Cyril Hrubis
2017-08-22 8:35 ` [LTP] [PATCH v3] " Xiong Zhou
2017-08-22 14:23 ` Cyril Hrubis
2017-08-23 4:15 ` Xiong Zhou
2017-08-23 8:40 ` Cyril Hrubis [this message]
2017-08-23 9:42 ` [LTP] [PATCH v4] " Xiong Zhou
2017-08-23 9:53 ` [LTP] [PATCH v3] " Cyril Hrubis
2017-08-23 13:15 ` [LTP] [PATCH v5] " Xiong Zhou
2017-08-23 13:35 ` Cyril Hrubis
2017-08-24 7:48 ` [LTP] [PATCH v6] " Xiong Zhou
2017-08-29 14:27 ` Cyril Hrubis
2017-09-01 3:00 ` [LTP] [PATCH v7] " Xiong Zhou
2017-09-05 12:06 ` Cyril Hrubis
2017-09-05 13:13 ` Xiong Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823084019.GA8175@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox