public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Sandeep Patil <sspatil@google.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] getcwd01: Remove unnecessary usage of temporary directory
Date: Mon, 28 Aug 2017 09:40:42 -0700	[thread overview]
Message-ID: <20170828164043.93407-2-sspatil@google.com> (raw)
In-Reply-To: <20170828164043.93407-1-sspatil@google.com>

The test checks for errors returned from the system call and
doesn't really need a temporary directory in order to do
that.

Signed-off-by: Sandeep Patil <sspatil@google.com>
---
 testcases/kernel/syscalls/getcwd/getcwd01.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/testcases/kernel/syscalls/getcwd/getcwd01.c b/testcases/kernel/syscalls/getcwd/getcwd01.c
index fdf306103..1199e9f2e 100644
--- a/testcases/kernel/syscalls/getcwd/getcwd01.c
+++ b/testcases/kernel/syscalls/getcwd/getcwd01.c
@@ -74,13 +74,7 @@ static void verify_getcwd(unsigned int n)
 	tst_res(TPASS | TTERRNO, "getcwd() failed as expected");
 }
 
-static void setup(void)
-{
-	SAFE_CHDIR("/tmp");
-}
-
 static struct tst_test test = {
-	.setup = setup,
 	.tcnt = ARRAY_SIZE(tcases),
 	.test = verify_getcwd
 };
-- 
2.14.1.342.g6490525c54-goog


  reply	other threads:[~2017-08-28 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 16:40 [LTP] [PATCH v2 0/2] Fix getcwd0[12] tests for Android devices Sandeep Patil
2017-08-28 16:40 ` Sandeep Patil [this message]
2017-08-29 11:21   ` [LTP] [PATCH v2 1/2] getcwd01: Remove unnecessary usage of temporary directory Cyril Hrubis
2017-08-28 16:40 ` [LTP] [PATCH v2 2/2] android: getcwd02: use temp dir from $TMPDIR if present Sandeep Patil
2017-08-29 11:22   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828164043.93407-2-sspatil@google.com \
    --to=sspatil@google.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox