public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Sandeep Patil <sspatil@google.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC][PATCH 0/2] Add support to mount 'tmpfs' for EROFS testing
Date: Mon, 28 Aug 2017 17:11:24 -0700	[thread overview]
Message-ID: <20170829001126.142076-1-sspatil@google.com> (raw)

There are several tests in LTP (especially the syscalls) that test for EROFS
error return in case of "read-only filesystem" that fail on Android (and possibly
other systems) because of the fact that they need to find a free
loopback device, create, format and mount a filesystem by default.

This makes all those tests flaky for number of reasons
 - Loopback device paths are different on Android (i.e. /dev/block/loopN)
	- This is very easily fixable though.
 - Filesystem tools are different on Android and in some cases non-existent.

For a test that checks for EROFS, going through the whole filesystem generation
and mounting is an overkill since the filesystem is unused after the mount anyway.

So, add support to mount 'tmpfs' (read-only if required) in libltp instead
of creating a filesystem and mounting a device. This simplifies a lot of tests
as mentioned in the changelog for PATCH 1/2.

Note: I've tested this on Android system as well as an ubuntu based machine.

Sandeep Patil (2):
  libltp: add support to mount tmpfs
  access04: use the new tmpfs mount for EROFS testing

 include/tst_test.h                          |  6 ++++++
 lib/tst_test.c                              | 17 +++++++++++++++++
 testcases/kernel/syscalls/access/access04.c |  6 +++---
 3 files changed, 26 insertions(+), 3 deletions(-)

-- 
2.14.1.342.g6490525c54-goog


             reply	other threads:[~2017-08-29  0:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29  0:11 Sandeep Patil [this message]
2017-08-29  0:11 ` [LTP] [RFC][PATCH 1/2] libltp: add support to mount tmpfs Sandeep Patil
2017-08-29 10:16   ` Cyril Hrubis
2017-08-30 11:27     ` Jan Stancek
2017-09-05 23:45       ` Sandeep Patil
2017-08-29  0:11 ` [LTP] [RFC][PATCH 2/2] access04: use the new tmpfs mount for EROFS testing Sandeep Patil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170829001126.142076-1-sspatil@google.com \
    --to=sspatil@google.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox