From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC][PATCH 1/2] libltp: add support to mount tmpfs
Date: Tue, 29 Aug 2017 12:16:28 +0200 [thread overview]
Message-ID: <20170829101627.GA31839@rei.lan> (raw)
In-Reply-To: <20170829001126.142076-2-sspatil@google.com>
Hi!
> Some tests go through losetup, create, format and mount
> filesystems only to run tests for 'EROFS' return value from
> system calls. The tests end up being flaky depending on the tools
> available on the platform. e.g. mkfs.<filesystem> tool is required for
> mounting a device with filesystem.
>
> If the test is only to check for EROFS, this can be achieved by simply
> doing a 'tmpfs' read-only mount in $tmpdir.
Using tmpfs for EROFS sounds like a good idea, that should be much
faster than loop device as well, but there is a catch. There most likely
are embedded Linux devices that do not have tmpfs support compiled in
and as it is this would break these testcases on such platforms.
What about we created even more high-level interface for this? For
instance we can add .needs_rofs flag to the tst_test structure (reuse
the mntpoint to mount it) and let the library handle the details. I.e.
go for tmpfs and if that fails fall back to loop mounted device.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-08-29 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 0:11 [LTP] [RFC][PATCH 0/2] Add support to mount 'tmpfs' for EROFS testing Sandeep Patil
2017-08-29 0:11 ` [LTP] [RFC][PATCH 1/2] libltp: add support to mount tmpfs Sandeep Patil
2017-08-29 10:16 ` Cyril Hrubis [this message]
2017-08-30 11:27 ` Jan Stancek
2017-09-05 23:45 ` Sandeep Patil
2017-08-29 0:11 ` [LTP] [RFC][PATCH 2/2] access04: use the new tmpfs mount for EROFS testing Sandeep Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829101627.GA31839@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox