public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH 1/1] lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373
@ 2017-08-31 16:21 Petr Vorel
  0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2017-08-31 16:21 UTC (permalink / raw)
  To: ltp

From: Petr Vorel <petr.vorel@gmail.com>

glibc 2.26 starts rejecting IPv6 addresses which do not comply RFC 2373.

commit 9a0cc8c1bd7645bf3c988890ffb59639c07a5812
Author: Florian Weimer <fweimer@redhat.com>
Date:   Fri Jun 23 22:51:00 2017 +0200

    inet_pton: Reject IPv6 addresses with many leading zeros [BZ #16637]

    2001:db8:00001::f is not a valid IPv6 address according to RFC 2373.

See also:
https://sourceware.org/bugzilla/show_bug.cgi?id=16637

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
 testcases/network/lib6/in6_01.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/testcases/network/lib6/in6_01.c b/testcases/network/lib6/in6_01.c
index f7186b480..3a96ed17d 100644
--- a/testcases/network/lib6/in6_01.c
+++ b/testcases/network/lib6/in6_01.c
@@ -40,8 +40,6 @@ static struct {
 	{ "::ffff:10.0.0.1", 1 },
 	{ "::fffe:10.0.0.1", 0 },
 	{ "::7fff:10.0.0.1", 0 },
-	{ "0:0:0:0:0:0:ffff:0a001", 0 },
-	{ "0:0:1:0:0:0:ffff:0a001", 0 },
 };
 
 #define MAPSIZE (sizeof(maptab)/sizeof(maptab[0]))
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [LTP] [PATCH 1/1] lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373
@ 2017-08-31 16:26 Petr Vorel
  0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2017-08-31 16:26 UTC (permalink / raw)
  To: ltp

glibc 2.26 starts rejecting IPv6 addresses which do not comply RFC 2373.

commit 9a0cc8c1bd7645bf3c988890ffb59639c07a5812
Author: Florian Weimer <fweimer@redhat.com>
Date:   Fri Jun 23 22:51:00 2017 +0200

    inet_pton: Reject IPv6 addresses with many leading zeros [BZ #16637]

    2001:db8:00001::f is not a valid IPv6 address according to RFC 2373.

See also:
https://sourceware.org/bugzilla/show_bug.cgi?id=16637

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/network/lib6/in6_01.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/testcases/network/lib6/in6_01.c b/testcases/network/lib6/in6_01.c
index f7186b480..3a96ed17d 100644
--- a/testcases/network/lib6/in6_01.c
+++ b/testcases/network/lib6/in6_01.c
@@ -40,8 +40,6 @@ static struct {
 	{ "::ffff:10.0.0.1", 1 },
 	{ "::fffe:10.0.0.1", 0 },
 	{ "::7fff:10.0.0.1", 0 },
-	{ "0:0:0:0:0:0:ffff:0a001", 0 },
-	{ "0:0:1:0:0:0:ffff:0a001", 0 },
 };
 
 #define MAPSIZE (sizeof(maptab)/sizeof(maptab[0]))
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [LTP] [PATCH 1/1] lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373
@ 2017-08-31 19:46 Petr Vorel
  0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2017-08-31 19:46 UTC (permalink / raw)
  To: ltp

glibc 2.26 starts rejecting IPv6 addresses which do not comply RFC 2373.

commit 9a0cc8c1bd7645bf3c988890ffb59639c07a5812
Author: Florian Weimer <fweimer@redhat.com>
Date:   Fri Jun 23 22:51:00 2017 +0200

    inet_pton: Reject IPv6 addresses with many leading zeros [BZ #16637]

    2001:db8:00001::f is not a valid IPv6 address according to RFC 2373.

See also:
https://sourceware.org/bugzilla/show_bug.cgi?id=16637

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/network/lib6/in6_01.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/testcases/network/lib6/in6_01.c b/testcases/network/lib6/in6_01.c
index f7186b480..3a96ed17d 100644
--- a/testcases/network/lib6/in6_01.c
+++ b/testcases/network/lib6/in6_01.c
@@ -40,8 +40,6 @@ static struct {
 	{ "::ffff:10.0.0.1", 1 },
 	{ "::fffe:10.0.0.1", 0 },
 	{ "::7fff:10.0.0.1", 0 },
-	{ "0:0:0:0:0:0:ffff:0a001", 0 },
-	{ "0:0:1:0:0:0:ffff:0a001", 0 },
 };
 
 #define MAPSIZE (sizeof(maptab)/sizeof(maptab[0]))
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [LTP] [PATCH 1/1] lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373
@ 2017-08-31 19:55 Petr Vorel
  2017-09-06 12:48 ` Cyril Hrubis
  0 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2017-08-31 19:55 UTC (permalink / raw)
  To: ltp

glibc 2.26 starts rejecting IPv6 addresses which do not comply RFC 2373.

commit 9a0cc8c1bd7645bf3c988890ffb59639c07a5812
Author: Florian Weimer <fweimer@redhat.com>
Date:   Fri Jun 23 22:51:00 2017 +0200

    inet_pton: Reject IPv6 addresses with many leading zeros [BZ #16637]

    2001:db8:00001::f is not a valid IPv6 address according to RFC 2373.

See also:
https://sourceware.org/bugzilla/show_bug.cgi?id=16637

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/network/lib6/in6_01.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/testcases/network/lib6/in6_01.c b/testcases/network/lib6/in6_01.c
index f7186b480..3a96ed17d 100644
--- a/testcases/network/lib6/in6_01.c
+++ b/testcases/network/lib6/in6_01.c
@@ -40,8 +40,6 @@ static struct {
 	{ "::ffff:10.0.0.1", 1 },
 	{ "::fffe:10.0.0.1", 0 },
 	{ "::7fff:10.0.0.1", 0 },
-	{ "0:0:0:0:0:0:ffff:0a001", 0 },
-	{ "0:0:1:0:0:0:ffff:0a001", 0 },
 };
 
 #define MAPSIZE (sizeof(maptab)/sizeof(maptab[0]))
-- 
2.14.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [LTP] [PATCH 1/1] lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373
  2017-08-31 19:55 [LTP] [PATCH 1/1] lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373 Petr Vorel
@ 2017-09-06 12:48 ` Cyril Hrubis
  2017-09-07 10:26   ` Alexey Kodanev
  0 siblings, 1 reply; 6+ messages in thread
From: Cyril Hrubis @ 2017-09-06 12:48 UTC (permalink / raw)
  To: ltp

Hi!
> glibc 2.26 starts rejecting IPv6 addresses which do not comply RFC 2373.
> 
> commit 9a0cc8c1bd7645bf3c988890ffb59639c07a5812
> Author: Florian Weimer <fweimer@redhat.com>
> Date:   Fri Jun 23 22:51:00 2017 +0200
> 
>     inet_pton: Reject IPv6 addresses with many leading zeros [BZ #16637]
> 
>     2001:db8:00001::f is not a valid IPv6 address according to RFC 2373.
> 
> See also:
> https://sourceware.org/bugzilla/show_bug.cgi?id=16637
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/network/lib6/in6_01.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/testcases/network/lib6/in6_01.c b/testcases/network/lib6/in6_01.c
> index f7186b480..3a96ed17d 100644
> --- a/testcases/network/lib6/in6_01.c
> +++ b/testcases/network/lib6/in6_01.c
> @@ -40,8 +40,6 @@ static struct {
>  	{ "::ffff:10.0.0.1", 1 },
>  	{ "::fffe:10.0.0.1", 0 },
>  	{ "::7fff:10.0.0.1", 0 },
> -	{ "0:0:0:0:0:0:ffff:0a001", 0 },
> -	{ "0:0:1:0:0:0:ffff:0a001", 0 },
                            ^
			    Shouldn't we just delete this leading zeroes
			    from the last two lines and be donw with it?

Or do you think that cases covered by this addresses without the leading
zeroes are already covered by the rest of the addresses in the
structure?

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [LTP] [PATCH 1/1] lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373
  2017-09-06 12:48 ` Cyril Hrubis
@ 2017-09-07 10:26   ` Alexey Kodanev
  0 siblings, 0 replies; 6+ messages in thread
From: Alexey Kodanev @ 2017-09-07 10:26 UTC (permalink / raw)
  To: ltp

Hi,
On 06.09.2017 15:48, Cyril Hrubis wrote:
> Hi!
>> glibc 2.26 starts rejecting IPv6 addresses which do not comply RFC 2373.
>>
>> commit 9a0cc8c1bd7645bf3c988890ffb59639c07a5812
>> Author: Florian Weimer <fweimer@redhat.com>
>> Date:   Fri Jun 23 22:51:00 2017 +0200
>>
>>     inet_pton: Reject IPv6 addresses with many leading zeros [BZ #16637]
>>
>>     2001:db8:00001::f is not a valid IPv6 address according to RFC 2373.
>>
>> See also:
>> https://sourceware.org/bugzilla/show_bug.cgi?id=16637
>>
>> Signed-off-by: Petr Vorel <pvorel@suse.cz>
>> ---
>>  testcases/network/lib6/in6_01.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/testcases/network/lib6/in6_01.c b/testcases/network/lib6/in6_01.c
>> index f7186b480..3a96ed17d 100644
>> --- a/testcases/network/lib6/in6_01.c
>> +++ b/testcases/network/lib6/in6_01.c
>> @@ -40,8 +40,6 @@ static struct {
>>  	{ "::ffff:10.0.0.1", 1 },
>>  	{ "::fffe:10.0.0.1", 0 },
>>  	{ "::7fff:10.0.0.1", 0 },
>> -	{ "0:0:0:0:0:0:ffff:0a001", 0 },
>> -	{ "0:0:1:0:0:0:ffff:0a001", 0 },
>                             ^
> 			    Shouldn't we just delete this leading zeroes
> 			    from the last two lines and be donw with it?

Agree, we should change the last segments to 'a001' and keep these
test-cases.

Best regards,
Alexey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20170907/420f1fa5/attachment.html>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-09-07 10:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-31 19:55 [LTP] [PATCH 1/1] lib6/in6_01.c: Remove IPv6 addresses which do not comply RFC 2373 Petr Vorel
2017-09-06 12:48 ` Cyril Hrubis
2017-09-07 10:26   ` Alexey Kodanev
  -- strict thread matches above, loose matches on Subject: below --
2017-08-31 19:46 Petr Vorel
2017-08-31 16:26 Petr Vorel
2017-08-31 16:21 Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox