From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/6] android: cve: Disable building cve-2017-5669
Date: Wed, 6 Sep 2017 15:17:12 +0200 [thread overview]
Message-ID: <20170906131712.GF24177@rei.lan> (raw)
In-Reply-To: <20170905213027.GP84377@sspatil-desktop.mtv.corp.google.com>
Hi!
> > shmat() is not available on Android/Binder
> >
> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> > ---
> > testcases/cve/Makefile | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/testcases/cve/Makefile b/testcases/cve/Makefile
> > index 04abc1f9c..5119c67cf 100644
> > --- a/testcases/cve/Makefile
> > +++ b/testcases/cve/Makefile
> > @@ -28,4 +28,8 @@ cve-2014-0196: LDLIBS += -lrt -lutil
> > cve-2017-2671: CFLAGS += -pthread
> > cve-2017-2671: LDLIBS += -lrt
> >
> > +ifeq ($(ANDROID),1)
> > +FILTER_OUT_MAKE_TARGETS += cve-2017-5669
> > +endif
> > +
> > include $(top_srcdir)/include/mk/generic_leaf_target.mk
>
> Do you have pointers to how you are build + testing with this? There seem to
> be some duplication of effort that I would like to avoid and make sure there
> is only 1 way in which tests like this are disabled out of build.
There was some initiall android support done by Steven Jackson, just
grep the git log for his name.
Basically what he did is to add a similar system we had for uClinux. You
are supposed to define shell variable ANDROID=1 when building for
android and the build system uses that to skip certain directories/files
from build.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-09-06 13:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 0:59 [LTP] [RFC PATCH 0/6] cve: fixes for Android Petr Vorel
2017-09-02 0:59 ` [LTP] [RFC PATCH 1/6] android: cve: Disable building cve-2017-5669 Petr Vorel
2017-09-05 17:47 ` enh
2017-09-05 21:30 ` Sandeep Patil
2017-09-06 13:17 ` Cyril Hrubis [this message]
2017-09-11 21:41 ` Petr Vorel
2017-09-12 18:21 ` enh
2017-09-12 21:27 ` Petr Vorel
2017-09-12 23:58 ` enh
2017-09-19 23:46 ` Sandeep Patil
2017-09-02 0:59 ` [LTP] [RFC PATCH 2/6] android: lib: Add missing include for tst_safe_pthread.h Petr Vorel
2017-09-05 19:07 ` enh
2017-09-02 0:59 ` [LTP] [RFC PATCH 3/6] android: Add pty.h header Petr Vorel
2017-09-05 19:09 ` enh
2017-09-02 0:59 ` [LTP] [RFC PATCH 4/6] android: cve: Fix build of most of the tests Petr Vorel
2017-09-06 13:20 ` Cyril Hrubis
2017-09-02 0:59 ` [LTP] [RFC PATCH 5/6] android: cve/stack_clash: Fix PAGE_MASK defined in <sys/user.h> Petr Vorel
2017-09-06 13:34 ` Cyril Hrubis
2017-09-02 0:59 ` [LTP] [RFC PATCH 6/6] android: cve/stack_clash: Fix warning Petr Vorel
2017-09-06 13:21 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906131712.GF24177@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox