From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RESEND][PATCH v3 2/2] syscalls/access04: use .needs_rofs flag for EROFS testing
Date: Tue, 19 Sep 2017 10:47:29 +0200 [thread overview]
Message-ID: <20170919084729.GB14133@rei> (raw)
In-Reply-To: <20170918165630.134076-3-sspatil@google.com>
Hi!
> Prefer to use the read-only bind mount of '/' over create,
> format and mount a filesystem image for testing 'EROFS' return
> value from access()
>
> Signed-off-by: Sandeep Patil <sspatil@google.com>
> ---
> testcases/kernel/syscalls/access/access04.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/access/access04.c b/testcases/kernel/syscalls/access/access04.c
> index dbb6d271a..626e6df2c 100644
> --- a/testcases/kernel/syscalls/access/access04.c
> +++ b/testcases/kernel/syscalls/access/access04.c
> @@ -125,9 +125,8 @@ static struct tst_test test = {
> .needs_tmpdir = 1,
> .needs_root = 1,
> .forks_child = 1,
> - .mount_device = 1,
> + .needs_rofs = 1,
> .mntpoint = MNT_POINT,
> - .mnt_flags = MS_RDONLY,
> .setup = setup,
> .test = verify_access,
> };
This is obviously correct, how many testcases can use this interface?
Lookint into the git tree, there is at least creat06 that could be
converted in the very same way, then there is a quite a bit of testcases
that will need to be converted to the new test library first.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-09-19 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 16:56 [LTP] [PATCH v3 0/2] libltp: add support for .needs_rofs for EROFS check Sandeep Patil
2017-09-18 16:56 ` [LTP] [RESEND][PATCH v3 1/2] libltp: add support to mount tmpfs for EROFS testing Sandeep Patil
2017-09-19 8:43 ` Cyril Hrubis
2017-09-19 18:30 ` Sandeep Patil
2017-09-18 16:56 ` [LTP] [RESEND][PATCH v3 2/2] syscalls/access04: use .needs_rofs flag " Sandeep Patil
2017-09-19 8:47 ` Cyril Hrubis [this message]
2017-09-19 18:28 ` Sandeep Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919084729.GB14133@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox