From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/access01: Set umask value before run case
Date: Mon, 25 Sep 2017 14:31:43 +0200 [thread overview]
Message-ID: <20170925123142.GA25748@rei> (raw)
In-Reply-To: <875562.19773227.1506083326749.JavaMail.zimbra@redhat.com>
Hi!
> We do umask(0) in ltp-pan:
>
> # umask
> 0077
>
> # /opt/ltp/runltp -p -d results -l RUNTEST.log -o RUNTEST.run.log -s access01 -f syscalls > /dev/null
>
> # cat /opt/ltp/results/RUNTEST.log
> Test Start Time: Fri Sep 22 14:24:28 2017
> -----------------------------------------
> Testcase Result Exit Value
> -------- ------ ----------
> access01 PASS 0
>
> I'm aware that running tests outside of ltp-pan is sometimes useful,
> so maybe we could add this to a library rather than in each test
> separately? What do you think Cyril?
Running tests outside ltp-pan should indeed possible but I'm not sure
that we want to change the umask in the test library. Most of the
testcases will run with the more restrictive umask just fine and I would
rather test the system in the default configuration. So changing it in
the test setup in this case sounds reasonable to me.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-09-25 12:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 13:04 [LTP] [PATCH] syscalls/access01: Set umask value before run case Bixuan Cui
2017-09-22 12:28 ` Jan Stancek
2017-09-25 2:34 ` Bixuan Cui
2017-09-25 12:31 ` Cyril Hrubis [this message]
2017-10-03 6:42 ` Jan Stancek
2017-10-03 15:52 ` Cyril Hrubis
2017-10-03 15:52 ` Cyril Hrubis
2017-10-09 5:27 ` Bixuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925123142.GA25748@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox