From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] commands/file: Compile in.c with -no-pie
Date: Tue, 26 Sep 2017 11:37:31 +0200 [thread overview]
Message-ID: <20170926093731.GA4884@rei.lan> (raw)
In-Reply-To: <20170926092950.10856-2-fenggw-fnst@cn.fujitsu.com>
Hi!
> On newer gcc, --enable-default-pie is enabled by default,
> thus in.c is compiled as position independent executable
> file, which leads to test failure unexpectedly.
>
> Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
> Signed-off-by: Fei Jie <feij.fnst@cn.fujitsu.com>
> ---
> testcases/commands/file/datafiles/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/commands/file/datafiles/Makefile b/testcases/commands/file/datafiles/Makefile
> index d3cb847..b26ce5b 100644
> --- a/testcases/commands/file/datafiles/Makefile
> +++ b/testcases/commands/file/datafiles/Makefile
> @@ -14,6 +14,7 @@
> top_srcdir ?= ../../../..
>
> include $(top_srcdir)/include/mk/env_pre.mk
> +CFLAGS += $(NOPIEFLAGS)
> INSTALL_DIR := testcases/data/file01
> INSTALL_TARGETS := in*
> include $(top_srcdir)/include/mk/generic_leaf_target.mk
Isn't adding an alternative expected string easier than this?
We do have, for instance, four alternative expected outputs for shell
scripts.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-09-26 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 9:29 [LTP] [PATCH 1/2] configure: Add configure check for GCC -no-pie Guangwen Feng
2017-09-26 9:29 ` [LTP] [PATCH 2/2] commands/file: Compile in.c with -no-pie Guangwen Feng
2017-09-26 9:37 ` Cyril Hrubis [this message]
2017-09-27 5:32 ` [LTP] [PATCH v2] commands/file: Fix for "executable" match failure on newer gcc Guangwen Feng
2017-09-27 9:15 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926093731.GA4884@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox