From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] syscalls, lib: Use SAFE_{BIND, LISTEN, SOCKET} macros
Date: Mon, 2 Oct 2017 17:21:09 +0200 [thread overview]
Message-ID: <20171002152109.GA3736@rei> (raw)
In-Reply-To: <20171002150417.jodtfynklflxe5pl@dell5510>
Hi!
> > > // SAFE_BIND
> > > @old_safe_bind depends on test_h@
> > > expression sockfd, sockaddr, addrlen;
> > > identifier cleanup_fn;
> > > expression e, x;
> > > constant TFAIL;
> > > @@
> > > -if (bind(sockfd, sockaddr, addrlen) < 0) {
> > > - tst_brkm(e, cleanup_fn, ...);
> > > (
> > > - return -1;
>
> > > )
> > > ... when != x & TFAIL
>
> > What does the last line do? I am guessing it prevents the substitution
> > if it finds TFAIL anywhere in the above expression.
> Precisely :-).
Shouldn't that be when != e & TFAIL? As far as I can tell the x is not
used in the matching part, or did I miss something?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-10-02 15:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 23:10 [LTP] [PATCH 1/1] syscalls, lib: Use SAFE_{BIND, LISTEN, SOCKET} macros Petr Vorel
2017-09-29 23:15 ` Petr Vorel
2017-10-02 11:00 ` Richard Palethorpe
2017-10-02 12:29 ` Petr Vorel
2017-10-02 14:51 ` Richard Palethorpe
2017-10-02 15:04 ` Petr Vorel
2017-10-02 15:21 ` Cyril Hrubis [this message]
2017-10-02 15:36 ` Petr Vorel
2017-10-03 11:43 ` Cyril Hrubis
2017-10-03 12:31 ` Petr Vorel
2017-10-03 12:56 ` Cyril Hrubis
2017-10-03 13:21 ` Petr Vorel
2017-10-03 18:08 ` Jan Stancek
2017-10-03 19:05 ` Cyril Hrubis
2017-10-03 14:28 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002152109.GA3736@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox