[LTP] [PATCH 1/1] syscalls, lib: Use SAFE_{BIND, LISTEN, SOCKET} macros

Cyril Hrubis
2017-10-03T19:05:41Z

Hi!
> > > Really nice solution :-).
> > > This script is really worth of adding into LTP (even it requires to check
> > > formatting).
> >
> > I will strip the old library parts, then we can add it, maybe we can
> > even use it as a commit hook or something to automatically check if
> > we could have used a SAFE_MACRO() instead of custom error handling...
> >
>
> As I was looking at changes, I came across:
> tst_brkm(TFAIL | TERRNO, ...);
>
> I guess most of these tst_brk TFAILs should be TBROKs, but that would be
> likely difficult to script.

Yes, we would have to review which of these are real TFAILs manually,
which could be done, but would be quite time consuming. So I stuck with
changes I can formally prove are equal.

--
Cyril Hrubis
chrubis@suse.cz