From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] syscalls, lib: Use SAFE_{BIND, LISTEN, SOCKET} macros
Date: Tue, 3 Oct 2017 13:43:49 +0200 [thread overview]
Message-ID: <20171003114349.GA19124@rei> (raw)
In-Reply-To: <20171002153616.k6fkz7fpzh2shzdc@dell5510>
Hi!
> > Shouldn't that be when != e & TFAIL? As far as I can tell the x is not
> > used in the matching part, or did I miss something?
> Sure, you're right, Cyril. Now I got your question Richard.
> I'm surprised that it work with x (result is the same).
I guess that this condition simply was always true, and it does not work
either way.
Anyway I got an idea yesterday and implemented a shell script that
generates a spatch based on function name and made it iterate over all
safe macros we have implemented making a git commit for each. The script
is attached for a reference.
I will look at the patches and do some minor adjustements now, there are
a few cases where the formatting ended up a bit confusing.
And I would consider these to be obvious enough to be commited without
review, but I can send them to ML if anyone wants to double check the
results.
--
Cyril Hrubis
chrubis@suse.cz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_safe_macros.sh
Type: application/x-sh
Size: 2280 bytes
Desc: not available
URL: <http://lists.linux.it/pipermail/ltp/attachments/20171003/23122597/attachment.sh>
next prev parent reply other threads:[~2017-10-03 11:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 23:10 [LTP] [PATCH 1/1] syscalls, lib: Use SAFE_{BIND, LISTEN, SOCKET} macros Petr Vorel
2017-09-29 23:15 ` Petr Vorel
2017-10-02 11:00 ` Richard Palethorpe
2017-10-02 12:29 ` Petr Vorel
2017-10-02 14:51 ` Richard Palethorpe
2017-10-02 15:04 ` Petr Vorel
2017-10-02 15:21 ` Cyril Hrubis
2017-10-02 15:36 ` Petr Vorel
2017-10-03 11:43 ` Cyril Hrubis [this message]
2017-10-03 12:31 ` Petr Vorel
2017-10-03 12:56 ` Cyril Hrubis
2017-10-03 13:21 ` Petr Vorel
2017-10-03 18:08 ` Jan Stancek
2017-10-03 19:05 ` Cyril Hrubis
2017-10-03 14:28 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003114349.GA19124@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox