public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v2 1/7] m4: Fix libkeyutils detection on 32-bit cross build
Date: Mon, 9 Oct 2017 17:06:26 +0200	[thread overview]
Message-ID: <20171009150626.GD25633@rei.lan> (raw)
In-Reply-To: <20171009110101.3329-2-pvorel@suse.cz>

Hi!
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  configure.ac       | 1 +
>  m4/ltp-keyutils.m4 | 6 +++---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 458a5b13f..0bae6ce3f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -36,6 +36,7 @@ AC_CHECK_HEADERS([ \
>      mm.h \
>      pthread.h \
>      sys/xattr.h \
> +    keyutils.h \
>      linux/genetlink.h \
>      linux/mempolicy.h \
>      linux/module.h \
> diff --git a/m4/ltp-keyutils.m4 b/m4/ltp-keyutils.m4
> index 74b7d3249..1434ca823 100644
> --- a/m4/ltp-keyutils.m4
> +++ b/m4/ltp-keyutils.m4
> @@ -18,7 +18,7 @@ dnl
>  dnl LTP_CHECK_KEYUTILS_SUPPORT
>  dnl ----------------------------
>  dnl
> -AC_DEFUN([LTP_CHECK_KEYUTILS_SUPPORT],[
> -AC_CHECK_HEADERS([keyutils.h], [keyutils_libs="-lkeyutils"])
> -AC_SUBST([KEYUTILS_LIBS], [$keyutils_libs])
> +AC_DEFUN([LTP_CHECK_KEYUTILS_SUPPORT], [
> +	AC_CHECK_LIB([keyutils], [add_key], [keyutils_libs="-lkeyutils"])
> +	AC_SUBST([KEYUTILS_LIBS], [$keyutils_libs])
>  ])

Okay, this fixes most of the problems, but the request_key tests are
still broken as far as I can tell. Since these use #ifdef
HAVE_KEYUTILS_H, which will still fail if 64bit library is present but
not the 32bit one, right? I suppose that it fails with missing symbols
for add_key() and request_key().

Afaik these should be converted to make use of the lapi/keyctl.h header
just like the add_key tests, right? Or did I miss something?

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2017-10-09 15:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09 11:00 [LTP] [RFC PATCH v2 0/7] Fix 32-bit cross compilation Petr Vorel
2017-10-09 11:00 ` [LTP] [RFC PATCH v2 1/7] m4: Fix libkeyutils detection on 32-bit cross build Petr Vorel
2017-10-09 15:06   ` Cyril Hrubis [this message]
2017-10-09 17:04     ` Petr Vorel
2017-10-09 11:00 ` [LTP] [RFC PATCH v2 2/7] m4: Fix libacl " Petr Vorel
2017-10-09 15:29   ` Cyril Hrubis
2017-10-09 11:00 ` [LTP] [RFC PATCH v2 3/7] m4: Simplify check for linux/can.h header Petr Vorel
2017-10-09 15:37   ` Cyril Hrubis
2017-10-09 11:00 ` [LTP] [RFC PATCH v2 4/7] m4: Simplify check for linux/keyctl.h header Petr Vorel
2017-10-09 11:00 ` [LTP] [RFC PATCH v2 5/7] m4: Fix libcrypto detection on 32-bit cross build Petr Vorel
2017-10-09 15:43   ` Cyril Hrubis
2017-10-09 11:01 ` [LTP] [RFC PATCH v2 6/7] make: Remove workarounds for build without libnuma Petr Vorel
2017-10-09 11:01 ` [LTP] [RFC PATCH v2 7/7] m4, kernel/lib: Detect libnuma presence in kernel libs Petr Vorel
2017-10-09 15:59   ` Cyril Hrubis
2017-10-09 17:05     ` Petr Vorel
2017-10-09 11:23 ` [LTP] [RFC PATCH v2 0/7] Fix 32-bit cross compilation Richard Palethorpe
2017-10-09 12:49   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171009150626.GD25633@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox