From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] android: io/diotest4: remove dependency on <sys/shm.h>
Date: Wed, 11 Oct 2017 14:15:06 +0200 [thread overview]
Message-ID: <20171011121505.GA12177@rei> (raw)
In-Reply-To: <20170919232713.57314-1-sspatil@google.com>
Hi!
> The dependency causes the test to fail build when being compiled against
> bionic. The code however only seem to need that header for 'SHMLBA'
> constant used to set the mmap'ed segment size. That is replaced by
> the page size with this change. Tested on both Android device and a
> x86 workstation successfully.
Looking at the test git log it contains reverse of this patch, the
getpagesize() was replaced with SHMLBA, unfortunately the commit log
does not say why.
Digging up in LTP mailing list pointed to these:
https://sourceforge.net/p/ltp/mailman/ltp-list/?viewmonth=200804
Also see this commit:
commit 512cb343ef35cb952b87405787f2325106b5f48c
Author: Helge Deller <deller@gmx.de>
Date: Fri Jun 16 15:55:23 2017 +0200
mmap01: fix testcase on hppa architecture
The mmap() syscall to map a file at any given page-aligned address (via the
MAP_FIXED flag) can fail on the hppa architecture due to cache colouring
requirements of the architecture.
So this will break on strange architectures such as sparc or hppa
because we do MAP_FIXED with unsuitable address.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-10-11 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 23:27 [LTP] [PATCH] android: io/diotest4: remove dependency on <sys/shm.h> Sandeep Patil
2017-10-11 12:15 ` Cyril Hrubis [this message]
2017-10-18 5:49 ` Sandeep Patil
2017-10-26 8:16 ` Cyril Hrubis
2017-11-06 18:37 ` Sandeep Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011121505.GA12177@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox