public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers3@gmail.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 3/4] syscalls/keyctl07: new test for oops when reading negative key
Date: Mon, 16 Oct 2017 12:47:48 -0700	[thread overview]
Message-ID: <20171016194748.GE121701@gmail.com> (raw)
In-Reply-To: <20171016102259.GB29957@rei>

On Mon, Oct 16, 2017 at 12:22:59PM +0200, Cyril Hrubis wrote:
> Hi!
> I've pushed all patches but this one, since it actually looks like a
> test bug when we oops the kernel since the test gets SIGKILL, which is
> the same signal the library uses for a timeout:
> 
>  $ ./keyctl07
>  tst_test.c:958: INFO: Timeout per run is 0h 05m 00s
>  keyctl07.c:72: INFO: trying to read from the negative key...
>  tst_test.c:1008: INFO: If you are running on slow machine, try
>  exporting LTP_TIMEOUT_MUL > 1
>  tst_test.c:1009: BROK: Test killed! (timeout?)
> 
> Can we, pretty please, run the test in a child process and wait it in
> the test function and report a failure instead? I fear that kind of test
> output will confuse people into thinking that this is a test problem
> rather than a kernel bug.
> 

Hi Cyril, I'll send out a new version that does that.  But please check that I'm
handling the exit status from the child process correctly because I wasn't 100%
sure how to do it.  (And I'm surprised more tests haven't run into this problem.
Maybe there should be something in the library for this, like being able to set
'.fail_on_sigkill = 1' in the 'struct tst_test'?  Or at least a different
version of tst_reap_children().)

Eric

  reply	other threads:[~2017-10-16 19:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 20:42 [LTP] [PATCH v2 0/4] ltp: add tests for some recently-fixed keyrings bugs Eric Biggers
2017-10-12 20:42 ` [LTP] [PATCH v2 1/4] lapi/keyctl.h: add a few missing definitions Eric Biggers
2017-10-12 20:42 ` [LTP] [PATCH v2 2/4] syscalls/keyctl06: new test for keyring_read() buffer overrun Eric Biggers
2017-10-12 20:42 ` [LTP] [PATCH v2 3/4] syscalls/keyctl07: new test for oops when reading negative key Eric Biggers
2017-10-16 10:22   ` Cyril Hrubis
2017-10-16 19:47     ` Eric Biggers [this message]
2017-10-17  9:19       ` Cyril Hrubis
2017-10-12 20:42 ` [LTP] [PATCH v2 4/4] syscalls/add_key03: new test for forging user keyrings Eric Biggers
2017-10-13  7:25 ` [LTP] [PATCH v2 0/4] ltp: add tests for some recently-fixed keyrings bugs Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016194748.GE121701@gmail.com \
    --to=ebiggers3@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox