From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 04/14] m4: Fix libaio detection on 32-bit cross build
Date: Tue, 17 Oct 2017 15:29:45 +0200 [thread overview]
Message-ID: <20171017132945.GA31490@rei> (raw)
In-Reply-To: <20171016154205.4814-5-pvorel@suse.cz>
Hi!
> + AC_TRY_LINK(... AC_DEFINE(HAVE_IO_SET_EVENTFD) ...)
^
Is this a forgotten placeholder?
> AC_TRY_LINK([#include <stdio.h>
> #include <libaio.h>
> ],
> - [io_set_eventfd(NULL, 0); return 0;
> - ],
> - [AC_DEFINE(HAVE_IO_SET_EVENTFD)
> - AC_MSG_RESULT(yes)],
> - [AC_MSG_RESULT(no)])],
> - AIO_LIBS="")])
> -AC_SUBST(AIO_LIBS)
> + [io_set_eventfd(NULL, 0); return 0;],
> + [AC_DEFINE(HAVE_IO_SET_EVENTFD, 1, [Define to 1 if you have `io_set_eventfd' function.])])
Okay this AC_TRY_LINK() actually works, but does not produce any output,
notice the AC_MSG_CHECKING() and AC_MSG_RESULT() in the original code.
I was going to suggest to use AC_CHECK_LIB() but the io_set_eventfd() is
inline function defined in the header so we have to stuck with
AC_TRY_LINK().
We also seem to have duplicit libaio.h check in configure.ac.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-10-17 13:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 15:41 [LTP] [PATCH v4 00/14] Fix 32-bit cross compilation Petr Vorel
2017-10-16 15:41 ` [LTP] [PATCH v4 01/14] lapi/keyctl.h: Add doc and reorder definitions Petr Vorel
2017-10-16 15:41 ` [LTP] [PATCH v4 02/14] syscalls/request_key: Port to use lapi/keyctl.h header Petr Vorel
2017-10-16 15:41 ` [LTP] [PATCH v4 03/14] m4: Fix libkeyutils detection on 32-bit cross build Petr Vorel
2017-10-17 12:42 ` Cyril Hrubis
2017-10-16 15:41 ` [LTP] [PATCH v4 04/14] m4: Fix libaio " Petr Vorel
2017-10-17 13:29 ` Cyril Hrubis [this message]
2017-10-16 15:41 ` [LTP] [PATCH v4 05/14] make: Remove workarounds for build without libnuma Petr Vorel
2017-10-16 15:41 ` [LTP] [PATCH v4 06/14] numa: Drop NUMA API v1 support Petr Vorel
2017-10-16 15:41 ` [LTP] [PATCH v4 07/14] numa: Drop NUMA_CPPFLAGS Petr Vorel
2017-10-16 15:41 ` [LTP] [PATCH v4 08/14] hotplug/memory_hotplug: Update TODO Petr Vorel
2017-10-16 15:42 ` [LTP] [PATCH v4 09/14] hotplug/memory_hotplug: Remove unused header Petr Vorel
2017-10-16 15:42 ` [LTP] [PATCH v4 10/14] hotplug/memory_hotplug: Exit with TCONF when NUMA headers not available Petr Vorel
2017-10-16 15:42 ` [LTP] [PATCH v4 11/14] m4, kernel/lib: Detect libnuma presence in kernel libs Petr Vorel
2017-10-16 15:42 ` [LTP] [PATCH v4 12/14] numa: Check for API >= v2 with autoconf Petr Vorel
2017-10-16 15:42 ` [LTP] [PATCH v4 13/14] numa: Remove HAVE_NUMA_ALLOC_ONNODE definition Petr Vorel
2017-10-16 15:42 ` [LTP] [PATCH v4 14/14] numa: Remove HAVE_NUMA_MOVE_PAGES definition Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017132945.GA31490@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox