From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5 07/12] hotplug/memory_hotplug: Remove unused header
Date: Thu, 26 Oct 2017 12:53:44 +0200 [thread overview]
Message-ID: <20171026105344.GD7806@rei> (raw)
In-Reply-To: <20171018111106.17215-8-pvorel@suse.cz>
Hi!
> #include "config.h"
> -#if HAVE_NUMA_H && HAVE_LINUX_MEMPOLICY_H && HAVE_NUMAIF_H
> -#include <linux/mempolicy.h>
> +#if HAVE_NUMA_H && HAVE_NUMAIF_H
I guess that we have the same definitions in the linux/mempolicy.h and
numaif.h, right? I wonder how we even could include both of them without
producing warnings for constant redefinitions, etc.
Anyway, can you please include a bit more explanation in the commit
message? Something along the lines that the constant are present in both
headers and that we only need to include one?
Otherwise it looks good to me.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-10-26 10:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 11:10 [LTP] [PATCH v5 00/12] Fix 32-bit cross compilation Petr Vorel
2017-10-18 11:10 ` [LTP] [PATCH v5 01/12] m4: Fix libaio detection on 32-bit cross build Petr Vorel
2017-10-26 10:44 ` Cyril Hrubis
2017-10-18 11:10 ` [LTP] [PATCH v5 02/12] kernel/io: Build all directories even without libaio Petr Vorel
2017-10-26 10:44 ` Cyril Hrubis
2017-10-18 11:10 ` [LTP] [PATCH v5 03/12] make: Remove workarounds for build without libnuma Petr Vorel
2017-10-26 10:45 ` Cyril Hrubis
2017-10-30 8:57 ` Petr Vorel
2017-10-18 11:10 ` [LTP] [PATCH v5 04/12] numa: Drop NUMA API v1 support Petr Vorel
2017-10-18 11:10 ` [LTP] [PATCH v5 05/12] numa: Drop NUMA_CPPFLAGS Petr Vorel
2017-10-18 11:11 ` [LTP] [PATCH v5 06/12] hotplug/memory_hotplug: Update TODO Petr Vorel
2017-10-18 11:11 ` [LTP] [PATCH v5 07/12] hotplug/memory_hotplug: Remove unused header Petr Vorel
2017-10-26 10:53 ` Cyril Hrubis [this message]
2017-10-18 11:11 ` [LTP] [PATCH v5 08/12] hotplug/memory_hotplug: Exit with TCONF when NUMA headers not available Petr Vorel
2017-10-26 11:04 ` Cyril Hrubis
2017-10-28 16:47 ` Petr Vorel
2017-10-31 12:50 ` Cyril Hrubis
2017-10-18 11:11 ` [LTP] [PATCH v5 09/12] m4, kernel/lib: Detect libnuma presence in kernel libs Petr Vorel
2017-10-18 11:11 ` [LTP] [PATCH v5 10/12] numa: Check for API >= v2 with autoconf Petr Vorel
2017-10-18 11:11 ` [LTP] [PATCH v5 11/12] numa: Remove HAVE_NUMA_ALLOC_ONNODE definition Petr Vorel
2017-10-18 11:11 ` [LTP] [PATCH v5 12/12] numa: Remove HAVE_NUMA_MOVE_PAGES definition Petr Vorel
2017-11-02 15:52 ` Cyril Hrubis
2017-11-07 20:07 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026105344.GD7806@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox