From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 03/18] hugeshmctl01: Fix synchronisation with child processes
Date: Tue, 31 Oct 2017 12:04:08 +0100 [thread overview]
Message-ID: <20171031110408.GC14550@rei.lan> (raw)
In-Reply-To: <20171026141447.26749-4-punit.agrawal@arm.com>
Hi!
> hugeshmctl01 spawns child processes to perform shm operations and uses
> signal (SIGUSR1) to communicate the completion of test 1, to the
> children waiting at sigprocmask(). However, there is no guarantee that a
> child has reached sigprocmask() before the parent issues a SIGUSR1 and
> things go wrong.
>
> This patch fixes this issue by 'stopping' the children, waiting for all
> of them and then issuing SIGCONT to communicate the completion.
>
> While we are at it, also handle unknown signals as a hint to exit the
> test with TBROK.
We do have a checkpoint synchronization primitives in the test library
exactly for this kind of synchronization. Can you, pretty please, use
them instead?
https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#229-fork-and-parent-child-synchronization
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-10-31 11:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 14:14 [LTP] [PATCH 00/18] Collection of fixes Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 01/18] Move check_hugepage() helper to mem/lib Punit Agrawal
2017-10-31 10:53 ` Cyril Hrubis
2017-10-31 12:45 ` Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 02/18] thp: ensure THP/hugetlbfs is available Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 03/18] hugeshmctl01: Fix synchronisation with child processes Punit Agrawal
2017-10-31 11:04 ` Cyril Hrubis [this message]
2017-10-26 14:14 ` [LTP] [PATCH 04/18] hugeshmctl01: Fix synchronization issue in parent process Punit Agrawal
2017-10-31 11:05 ` Cyril Hrubis
2017-10-26 14:14 ` [LTP] [PATCH 05/18] hugeshmctl02: Fix allocation size for odd number of hugepages Punit Agrawal
2017-10-31 11:05 ` Cyril Hrubis
2017-10-26 14:14 ` [LTP] [PATCH 06/18] hugeshmget02: add missing SHM_HUGETLB flag on segment creation Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 07/18] vma03: accept ENOMEM return value from mremap Punit Agrawal
2017-10-31 11:11 ` Cyril Hrubis
2017-11-14 13:10 ` Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 08/18] creat08: ensure test directories are created in /tmp/ Punit Agrawal
2017-10-31 11:07 ` Cyril Hrubis
2017-10-31 12:46 ` Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 09/18] kill05: fix race on getpwnam Punit Agrawal
2017-10-31 12:01 ` Cyril Hrubis
2017-11-14 13:11 ` Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 10/18] sigwaitinfo01: fix race between sending and dequeueing RT signals Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 11/18] sigwaitinfo: catch SEGV and report success for bad_address2 testcase Punit Agrawal
2017-10-31 12:12 ` Cyril Hrubis
2017-10-26 14:14 ` [LTP] [PATCH 12/18] inotify: fix inotify.h breakage Punit Agrawal
2017-10-31 11:16 ` Cyril Hrubis
2017-10-26 14:14 ` [LTP] [PATCH 13/18] syscalls/mount03: Copy setuid_test to execute instead of 'TEST FILE' Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 14/18] ioctl: fix stty usage for busybox Punit Agrawal
2017-10-31 12:36 ` Cyril Hrubis
2017-10-26 14:14 ` [LTP] [PATCH 15/18] getdtablesize01: Handle ENFILE errno Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 16/18] perf_event_open: Handle absence of PMU gracefully Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 17/18] hotplug/cpu_hotplug: Repopulate cgroup:cpusets after testing hotplug Punit Agrawal
2017-10-26 14:14 ` [LTP] [PATCH 18/18] hotplug/cpu_hotplug: Remove bashism disown from kill_pid() Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031110408.GC14550@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox