From: Punit Agrawal <punit.agrawal@arm.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 08/13] sigwaitinfo01: catch SEGV and report success for bad_address2 testcase
Date: Tue, 14 Nov 2017 15:59:24 +0000 [thread overview]
Message-ID: <20171114155929.24237-9-punit.agrawal@arm.com> (raw)
In-Reply-To: <20171114155929.24237-1-punit.agrawal@arm.com>
The bad_address2 testcase passes (void *)1 as a sigset pointer to the
sigwaitinfo syscall. Unsurprisingly, this segfaults in libc rather than
returning -1 (errno = EFAULT) as LTP expects.
Instead, fork a child process which registers a SIGSEGV handler to catch
any SEGV's generated by the sigwaitinfo syscall. The signal handler
exits the child process with a return code which is checked by the
parent to evaluate test outcome.
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
---
.../kernel/syscalls/sigwaitinfo/sigwaitinfo01.c | 29 ++++++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/sigwaitinfo/sigwaitinfo01.c b/testcases/kernel/syscalls/sigwaitinfo/sigwaitinfo01.c
index 16b5096b8..8f517e918 100644
--- a/testcases/kernel/syscalls/sigwaitinfo/sigwaitinfo01.c
+++ b/testcases/kernel/syscalls/sigwaitinfo/sigwaitinfo01.c
@@ -361,10 +361,35 @@ void test_bad_address(swi_func sigwaitinfo, int signo)
kill(child, SIGTERM);
}
+static void segv_handler(int signo)
+{
+ /* SIGSEGV is expected, exit with 0xff */
+ _exit(0xff);
+}
+
void test_bad_address2(swi_func sigwaitinfo, int signo)
{
- TEST(sigwaitinfo((void *)1, NULL, NULL));
- REPORT_SUCCESS(-1, EFAULT);
+ pid_t pid;
+ int status;
+
+ switch (pid = FORK_OR_VFORK()) {
+ case -1:
+ tst_brkm(TBROK | TERRNO, NULL, "fork() failed");
+ case 0:
+ signal(SIGSEGV, segv_handler);
+ TEST(sigwaitinfo((void *)1, NULL, NULL));
+
+ _exit(0);
+ break;
+ default:
+ break;
+ }
+
+ SUCCEED_OR_DIE(waitpid, "waitpid failed", pid, &status, 0);
+ if (WIFEXITED(status) && WEXITSTATUS(status) == 0xff)
+ tst_resm(TPASS, "Test passed");
+ else
+ tst_resm(TFAIL, "Unrecognised child exit code");
}
void test_bad_address3(swi_func sigwaitinfo, int signo)
--
2.14.2
next prev parent reply other threads:[~2017-11-14 15:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 15:59 [LTP] [PATCH v2 00/13] Collection of fixes Punit Agrawal
2017-11-14 15:59 ` [LTP] [PATCH v2 01/13] Move check_hugepage() helper to mem/lib Punit Agrawal
2017-11-14 15:59 ` [LTP] [PATCH v2 02/13] thp: ensure THP/hugetlbfs is available Punit Agrawal
2017-11-27 16:20 ` Cyril Hrubis
2017-11-27 16:59 ` Punit Agrawal
2017-11-29 12:44 ` Cyril Hrubis
2017-11-29 13:29 ` Punit Agrawal
2017-11-29 14:34 ` Cyril Hrubis
2017-11-14 15:59 ` [LTP] [PATCH v2 03/13] hugeshmctl01: Convert to LTP synchronisation primitives Punit Agrawal
2017-11-27 16:52 ` Cyril Hrubis
2017-11-27 17:34 ` Punit Agrawal
2017-11-14 15:59 ` [LTP] [PATCH v2 04/13] hugeshmctl01: Fix warning about signed/unsigned comparison Punit Agrawal
2017-11-14 15:59 ` [LTP] [PATCH v2 05/13] hugeshmctl02: Fix allocation size for odd number of hugepages Punit Agrawal
2017-11-14 15:59 ` [LTP] [PATCH v2 06/13] hugeshmget02: add missing SHM_HUGETLB flag on segment creation Punit Agrawal
2017-11-14 15:59 ` [LTP] [PATCH v2 07/13] sigwaitinfo01: fix race between sending and dequeueing RT signals Punit Agrawal
2017-11-14 15:59 ` Punit Agrawal [this message]
2017-11-29 10:29 ` [LTP] [PATCH v2 08/13] sigwaitinfo01: catch SEGV and report success for bad_address2 testcase Cyril Hrubis
2017-11-29 13:25 ` Punit Agrawal
2017-11-29 15:33 ` Cyril Hrubis
2017-11-14 15:59 ` [LTP] [PATCH v2 09/13] syscalls/mount03: Copy setuid_test to execute instead of 'TEST FILE' Punit Agrawal
2017-11-29 13:20 ` Cyril Hrubis
2017-11-29 16:50 ` Punit Agrawal
2017-11-30 12:21 ` Cyril Hrubis
2017-11-30 12:56 ` Punit Agrawal
2017-11-30 13:17 ` Cyril Hrubis
2017-11-30 15:56 ` Punit Agrawal
2017-11-14 15:59 ` [LTP] [PATCH v2 10/13] getdtablesize01: Handle ENFILE errno Punit Agrawal
2017-11-30 13:12 ` Cyril Hrubis
2017-11-30 16:06 ` Punit Agrawal
2017-11-30 16:20 ` Cyril Hrubis
2017-11-30 16:41 ` Suzuki K Poulose
2017-12-01 13:38 ` Cyril Hrubis
2017-12-01 15:30 ` Punit Agrawal
2017-11-14 15:59 ` [LTP] [PATCH v2 11/13] perf_event_open: Handle absence of PMU gracefully Punit Agrawal
2017-11-14 15:59 ` [LTP] [PATCH v2 12/13] hotplug/cpu_hotplug: Repopulate cgroup:cpusets after testing hotplug Punit Agrawal
2017-11-30 13:58 ` Cyril Hrubis
2017-12-01 16:00 ` Punit Agrawal
2017-11-14 15:59 ` [LTP] [PATCH v2 13/13] hotplug/cpu_hotplug: Remove bashism disown from kill_pid() Punit Agrawal
2017-11-21 16:15 ` [LTP] [PATCH v2 00/13] Collection of fixes Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114155929.24237-9-punit.agrawal@arm.com \
--to=punit.agrawal@arm.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox