public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] fs_fill: switch the SAFE MACROs back to ordinary	syscall
Date: Mon, 20 Nov 2017 14:19:52 +0100	[thread overview]
Message-ID: <20171120131952.GA22113@rei.lan> (raw)
In-Reply-To: <1515676468.42550872.1511176722601.JavaMail.zimbra@redhat.com>

Hi!
> >   safe_macros.c:225: BROK: tst_fill_fs.c:43:
> >   open(mntpoint/thread48/file0,65,0700) failed: ENOSPC
> >   safe_macros.c:169: BROK: fs_fill.c:49: mkdir(mntpoint/thread21,0700)
> >   failed: ENOSPC
> > 
> > Signed-off-by: Li Wang <liwang@redhat.com>
> 
> Pushed.

I do not like that the worker exits prematurely here if the mkdir fails,
that's why I suggested to mkdir() all the directories before we attempt
to run the the worker threads.

But I can always change that in a follow up patch...

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2017-11-20 13:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10 11:15 [LTP] [PATCH] fs_fill: switch the SAFE MACROs back to ordinary syscall Li Wang
2017-11-20 11:18 ` Jan Stancek
2017-11-20 13:19   ` Cyril Hrubis [this message]
2017-11-21  4:14     ` Li Wang
2017-11-21  9:44       ` Cyril Hrubis
2017-11-22 12:48         ` Jan Stancek
2017-11-22 12:51           ` Jan Stancek
2017-11-22 13:29             ` Cyril Hrubis
2017-11-22 13:27           ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171120131952.GA22113@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox