From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] hugetlb: fix warnings in cleanup()
Date: Thu, 30 Nov 2017 15:50:27 +0100 [thread overview]
Message-ID: <20171130145027.GG2924@rei> (raw)
In-Reply-To: <20171027085632.18245-1-liwang@redhat.com>
Hi!
The fix is OK, but we may as well do it better, if we move completly the
logic to the library we do not have to repeat the code in each test.
So what about adding two functions save_nr_hugepages() and
restore_nr_hugepages() to the library and call these from the test setup
and cleanup?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-11-30 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 8:56 [LTP] [PATCH] hugetlb: fix warnings in cleanup() Li Wang
2017-11-30 14:50 ` Cyril Hrubis [this message]
2017-12-01 3:05 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130145027.GG2924@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox