From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] runltp: skipfile: skipped test cases should be visible as TCONF in results
Date: Tue, 19 Dec 2017 13:59:52 +0100 [thread overview]
Message-ID: <20171219125952.GE28293@rei> (raw)
In-Reply-To: <1513073830-17174-1-git-send-email-naresh.kamboju@linaro.org>
Hi!
> + if [ -n "${SKIPFILE}" ]; then
> + while read -r test_line; do
> + case "${test_line}" in \#*) continue ;; esac
> + if [ -n "${test_line}" ]; then
> + # test_name is first column of each line in SKIPFILE
> + test_name=$(echo ${test_line} | awk '{print $1}')
> + sed -i "/\<${test_name}\>/c\\${test_name} exit 32;" alltests
> + fi
> + done < ${SKIPFILE}
This could be written in a simpler form:
for test_name in $(awk '{print $1}' "$SKIPFILE"); do
case "${test_name}" in \#*) continue;; esac
sed -i "/\<${test_name}\>/c\\${test_name} exit 32;" alltests
done
Other than that it looks fine.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-12-19 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 10:17 [LTP] [PATCH] runltp: skipfile: skipped test cases should be visible as TCONF in results Naresh Kamboju
2017-12-19 12:59 ` Cyril Hrubis [this message]
2017-12-19 14:22 ` Naresh Kamboju
2017-12-20 10:28 ` Cyril Hrubis
2017-12-20 13:04 ` Naresh Kamboju
-- strict thread matches above, loose matches on Subject: below --
2017-12-20 13:03 Naresh Kamboju
2017-12-20 14:02 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219125952.GE28293@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox