Linux Test Project
 help / color / mirror / Atom feed
From: Michael Moese <mmoese@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] Add library support for /proc/sys/kernel/tainted
Date: Thu, 25 Jan 2018 15:20:58 +0100	[thread overview]
Message-ID: <20180125142058.ubfl2357cyry3erj@linux.suse> (raw)
In-Reply-To: <20180125132814.GA19878@rei.lan>

Hi,

On Thu, Jan 25, 2018 at 02:28:15PM +0100, Cyril Hrubis wrote:

> I would have probably put these into an array of structures indexed by
> the position of the flag bit, but it's fine as it is as well.

I considered this, but as I only have the bits, I would have to 
introduce a second parameter, to get it in a consecutive manner. 

I was thinking this would be shorter for now - if we don't like it I 
can change this anyway, later.

Thanks for the review

Michael
- 
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

      reply	other threads:[~2018-01-25 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25 12:16 [LTP] [PATCH v2] Add library support for /proc/sys/kernel/tainted Michael Moese
2018-01-25 12:26 ` Michael Moese
2018-01-25 13:28 ` Cyril Hrubis
2018-01-25 14:20   ` Michael Moese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125142058.ubfl2357cyry3erj@linux.suse \
    --to=mmoese@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox