public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] Add read_all file systems test
Date: Tue, 13 Feb 2018 15:15:35 +0100	[thread overview]
Message-ID: <20180213141535.GA10493@rei> (raw)
In-Reply-To: <87mv0dxccb.fsf@rpws.prws.suse.cz>

Hi!
> >> +	queue_destroy(q, 1);
> >> +	fflush(stdout);
> >
> > What are trying to flush here? The tst_res() messages are printed
> > into the stderr btw.
> 
> I found that the pass message was being written after some of the
> childrens' information messages. Calling fflush on stdout prevents that
> from happening even though it is the wrong fd...

You mean the tst_res(TPASS, ...) called after the tst_reap_children() ?

That is really strange since at that time the processes had called
exit() already and the buffers should have been flushed at that point.
I.e. if we haven't flushed it in the worker_run() the exit() should take
care of that, which is guaranteed to run before we return from the
tst_reap_children().

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2018-02-13 14:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19 16:37 [LTP] [PATCH v2] Add read_all file systems test Richard Palethorpe
2018-01-22 13:21 ` Cyril Hrubis
2018-02-13 13:12   ` Richard Palethorpe
2018-02-13 14:15     ` Cyril Hrubis [this message]
2018-02-13 15:33       ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213141535.GA10493@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox