From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/2] lib: TCONF on ESOCKTNOSUPPORT and EPROTONOSUPPORT in SAFE_SOCKET()
Date: Wed, 28 Feb 2018 13:04:07 +0100 [thread overview]
Message-ID: <20180228120406.GA19317@rei> (raw)
In-Reply-To: <20180227180044.21867-2-pvorel@suse.cz>
Hi!
> + if (rval < 0)
> + tst_brkm((errno == EPROTONOSUPPORT || errno == ESOCKTNOSUPPORT ? TCONF : TBROK)
> + | TERRNO, cleanup_fn, "%s:%d: socket(%d, %d, %d) failed",
> + file, lineno, domain, type, protocol);
This is kind of ugly code, can we please write it more readable?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-02-28 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 18:00 [LTP] [RFC PATCH 0/2] netstress, lib: TCONF on "not supported" in SAFE_SOCKET() Petr Vorel
2018-02-27 18:00 ` [LTP] [RFC PATCH 1/2] lib: TCONF on ESOCKTNOSUPPORT and EPROTONOSUPPORT " Petr Vorel
2018-02-28 12:04 ` Cyril Hrubis [this message]
2018-02-27 18:00 ` [LTP] [RFC PATCH 2/2] tst_netload: Exit with TCONF when netstress exit with CONF Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228120406.GA19317@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox