From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] commands/sysctl: Add new regression test for invalid sched_time_avg
Date: Wed, 14 Mar 2018 18:01:49 +0100 [thread overview]
Message-ID: <20180314170148.GC27794@rei> (raw)
In-Reply-To: <5A9F61AF.6070008@cn.fujitsu.com>
Hi!
> > What is this sleep good for? Do we wait here for the kernel to crash?
> On my RHEL6, restoring the original value immediately after setting an
> invalid value always didn't
> trigger a hang in time, so we just wait a moment for kernel to hang.
Shouldn't the kernel crash just by setting the avg_ms to 0 or do I
misunderstand the kernel commit changelog?
Or is the offending code that crashes the kernel invoked asynchronously
so that the value is picked up later by the scheduller? If so I would
prefer removing the sleep anyways since the test will fail if we happen
to be able to write 0 to the file anyways which is IMHO enough to inform
the user about the present bug.
Other than that the test looks fine.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-03-14 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 8:17 [LTP] [PATCH] commands/sysctl: Add new regression test for invalid sched_time_avg Xiao Yang
2018-02-12 9:03 ` Xiao Yang
2018-03-02 9:19 ` Xiao Yang
2018-03-06 12:42 ` Cyril Hrubis
2018-03-07 3:51 ` Xiao Yang
2018-03-14 17:01 ` Cyril Hrubis [this message]
2018-03-15 8:22 ` [LTP] [PATCH v3] " Xiao Yang
2018-03-15 12:21 ` Cyril Hrubis
2018-03-15 8:27 ` [LTP] [PATCH] " Xiao Yang
2018-03-07 4:35 ` [LTP] [PATCH v2] " Xiao Yang
2018-03-14 1:26 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314170148.GC27794@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox