From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Make floating point tests Android-compatible
Date: Tue, 27 Mar 2018 16:08:35 +0200 [thread overview]
Message-ID: <20180327140835.GB28115@rei> (raw)
In-Reply-To: <CAFt2AZUhp9tuWOVd-t-ij-eG-21+DEqeXE5XCwK=tQ8DmOnAgg@mail.gmail.com>
Hi!
> Android does not implement pthread_cancel. The function is replaced
> by a no-op in a compatibility header. In most cases, the only side
> effect is that threads cannot be interrupted and have to exit normally.
> However, floating point tests are calling pthread_cancel and waiting for
> a thread doing pthread_sigwait to be finished (Which will never happen).
>
> This patch implements the same logic using pthread_kill with SIGUSR2
> instead, allowing the tests to run under Android.
First of all the patch is mangled, probaly by your email client, check
its settings for attachements.
Secondly, looking at the patch, do we really have to join the signal
handler thread at the end? Cannot we just delete the the
pthreat_cancel() and pthread_join() for the sig_hand and be done with
it?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-03-27 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 19:48 [LTP] [PATCH] Make floating point tests Android-compatible Erick Reyes
2018-03-23 20:57 ` Erick Reyes
2018-03-26 11:18 ` Cyril Hrubis
2018-03-27 14:08 ` Cyril Hrubis [this message]
2018-04-03 1:41 ` Erick Reyes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327140835.GB28115@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox