From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v3 2/5] tst_test.sh: Introduce TST_NO_DEFAULT_RUN
Date: Wed, 4 Apr 2018 15:15:32 +0200 [thread overview]
Message-ID: <20180404131532.GA11423@x230> (raw)
In-Reply-To: <20180404130806.GG32109@rei>
Hi,
> > -if [ -z "$LTPROOT" ]; then
> > - export LTPROOT="$PWD"
> > - export TST_DATAROOT="$LTPROOT/datafiles"
> > -else
> > - export TST_DATAROOT="$LTPROOT/testcases/data/$TST_ID"
> > -fi
> > + if [ -z "$LTPROOT" ]; then
> > + export LTPROOT="$PWD"
> > + export TST_DATAROOT="$LTPROOT/datafiles"
> > + else
> > + export TST_DATAROOT="$LTPROOT/testcases/data/$TST_ID"
> > + fi
> I guess that we may want to initialize the TST_ID, LTPROOT and
> TST_DATAROOT regardless, otherwise this looks pretty much
> straighforward and okay.
Thanks for feedback, Cyril!
I'll change it in v4.
Kind regards,
Petr
next prev parent reply other threads:[~2018-04-04 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 15:47 [LTP] [RFC PATCH v3 0/5] Rewriting network tests into new shell API Petr Vorel
2018-04-03 15:47 ` [LTP] [RFC PATCH v3 1/5] tst_net.sh: Support both old and new shell APIs + rename it Petr Vorel
2018-04-04 13:37 ` Alexey Kodanev
2018-04-03 15:47 ` [LTP] [RFC PATCH v3 2/5] tst_test.sh: Introduce TST_NO_DEFAULT_RUN Petr Vorel
2018-04-04 13:08 ` Cyril Hrubis
2018-04-04 13:15 ` Petr Vorel [this message]
2018-04-03 15:47 ` [LTP] [RFC PATCH v3 3/5] network.sh: Migrate to new shell API Petr Vorel
2018-04-03 15:47 ` [LTP] [RFC PATCH v3 4/5] network/interface: Cleanup if4-addr-change Petr Vorel
2018-04-03 15:47 ` [LTP] [RFC PATCH v3 5/5] net: Migrate test_net_stress.sh and it's dependencies to new shell API Petr Vorel
2018-04-04 13:59 ` Alexey Kodanev
2018-04-04 14:33 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404131532.GA11423@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox