public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] syscalls/preadv01: Run test for all filesystems
Date: Thu, 5 Apr 2018 13:02:42 +0200	[thread overview]
Message-ID: <20180405110242.GA22835@rei> (raw)
In-Reply-To: <5AC600E2.5020305@cn.fujitsu.com>

Hi!
> > Looking at the test running it for all filesystems would not make much
> > sense as it is since as far as I can tell:
> >
> > 1) setup() creates a file and writes data to it
> >     - dirty pagecache record is created
> >
> > 2) test() reads data from the file
> >     - kernel will copy the data from pagecache
> >
> > 3) test library cleanup will umount() the device
> >     - dirty pagecache is written at this point
> >
> > So we will not reach any filesystem specific code at all.
> >
> > I guess that we may fix that by opening second file descriptor with
> > O_DIRECT which would bypass pagecache so each read/write request would
> > trigger I/O request from the block device.
> Hi Cyril,
> 
> Sorry, i ignored the fact that they use pagecache.
> Can we just keep them and add two new tests as you suggested?

I was simply thinking about opening second fd with O_DIRECT in the test
setup and running the test twice, once for the regular fd and once for
the O_DIRECT one, however creating new test would work as well and may
be even cleaner solution.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2018-04-05 11:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30  8:53 [LTP] [PATCH 1/2] syscalls/preadv01: Run test for all filesystems Xiao Yang
2018-03-30  8:53 ` [LTP] [PATCH 2/2] syscalls/pwritev01: " Xiao Yang
2018-04-05  9:52 ` [LTP] [PATCH 1/2] syscalls/preadv01: " Cyril Hrubis
2018-04-05 10:56   ` Xiao Yang
2018-04-05 11:02     ` Cyril Hrubis [this message]
2018-04-06 10:50       ` [LTP] [PATCH v2 1/2] preadv/preadv03.c: Add new testcase Xiao Yang
2018-04-06 10:50         ` [LTP] [PATCH v2 2/2] pwritev/pwritev03.c: " Xiao Yang
2018-04-06 13:02         ` [LTP] [PATCH v2 1/2] preadv/preadv03.c: " Cyril Hrubis
2018-04-09  3:24           ` [LTP] [PATCH v3 " Xiao Yang
2018-04-09  3:24             ` [LTP] [PATCH v3 2/2] pwritev/pwritev03.c: " Xiao Yang
2018-04-09 12:57             ` [LTP] [PATCH v3 1/2] preadv/preadv03.c: " Cyril Hrubis
2018-04-10  2:32               ` [LTP] [PATCH v4 " Xiao Yang
2018-04-10  2:32                 ` [LTP] [PATCH v4 2/2] pwritev/pwritev03.c: " Xiao Yang
2018-04-12 11:15                 ` [LTP] [PATCH v4 1/2] preadv/preadv03.c: " Cyril Hrubis
2018-04-10  2:42               ` [LTP] [PATCH v3 " Xiao Yang
2018-04-09  3:34           ` [LTP] [PATCH v2 " Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180405110242.GA22835@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox