public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] commands: Remove all test cases
Date: Thu, 26 Apr 2018 19:27:13 +0200	[thread overview]
Message-ID: <20180426172713.GB14157@x230> (raw)
In-Reply-To: <b72b277b-e8e0-d69c-b918-bd48341c2a1d@oracle.com>

Hi,

> On 04/26/2018 04:24 PM, Sebastian Chlad wrote:
> > Test cases testing commands are often outdated or not maintained.
> > Those test cases also do not fit in with current LTP project status.

> > Signed-off-by: Sebastian Chlad <schlad@suse.de>

...

> > diff --git a/testcases/commands/keyctl/keyctl01.sh b/testcases/commands/keyctl/keyctl01.sh
> > deleted file mode 100644
> > index 3fda3893b..000000000
> > --- a/testcases/commands/keyctl/keyctl01.sh
...
> > -# This is a regression test about potential uninitialized variable,
> > -# the test can crash the buggy kernel, and the bug has been fixed in:
> > -#
> > -#   commit 38327424b40bcebe2de92d07312c89360ac9229a
> > -#   Author: Dan Carpenter <dan.carpenter@oracle.com>
> > -#   Date:   Thu Jun 16 15:48:57 2016 +0100
> > -#
> > -#   KEYS: potential uninitialized variable
> > -#

...

> > --- a/testcases/commands/sysctl/sysctl01.sh
...
> > -# Description:
> > -# This is a regression test for invalid value of sysctl_sched_time_avg.
> > -# System will hang if user set sysctl_sched_time_avg to 0 on buggy kernel.
> > -#
> > -# The kernel bug has been fixed in kernel:
> > -# '5ccba44ba118("sched/sysctl: Check user input value of sysctl_sched_time_avg")'
> > -

> And those tests also don't fit?


sysctl and keyctl are actually testing kernel bugs. 
Other kernel related (at least lsmod, mkfs, mkswap, unshare, ldd, gdb) + TPM tools
(tpm-tools, ...) are probably valid.

I guess most of user space tools not related to kernel (cp, cron, df, ln, tar, unzip, wc,
which) are questionable.
du01 and ar01 are mentioned in git log to catch some bug, so we'd have to carefully check
one by one if we want to remove them (and remove them in separate commits, but that's
obvious).

Kind regards,
Petr

  parent reply	other threads:[~2018-04-26 17:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 13:24 [LTP] Commands test cases Sebastian Chlad
2018-04-26 13:24 ` [LTP] [PATCH] commands: Remove all " Sebastian Chlad
2018-04-26 13:47   ` Petr Vorel
2018-04-26 14:48     ` Sebastian Chlad
2018-04-27  2:59     ` Li Wang
2018-04-26 14:28   ` Alexey Kodanev
2018-04-26 14:49     ` Sebastian Chlad
2018-04-27  7:20       ` Jan Stancek
2018-04-27  7:41         ` Li Wang
2018-04-26 17:27     ` Petr Vorel [this message]
2018-04-27  0:35       ` Xiao Yang
2018-04-27  0:35       ` Xiao Yang
2018-04-27  7:02         ` Petr Vorel
2018-04-27 11:35       ` Cyril Hrubis
2018-04-27 11:37         ` Cyril Hrubis
2018-05-16 10:12         ` Petr Vorel
2018-05-25 14:36           ` Sebastian Chlad
2018-05-29 15:13           ` =?unknown-8bit?q?Myl=C3=A8ne?= Josserand
2018-05-30  9:31             ` Cyril Hrubis
2018-06-04  6:34             ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426172713.GB14157@x230 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox