From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] cve-2017-16939: drop linux/xfrm.h include
Date: Thu, 3 May 2018 10:45:58 +0200 [thread overview]
Message-ID: <20180503084558.GD29568@rei> (raw)
In-Reply-To: <d54cb909eacb6c2fe6b11f7e187862ef3070499c.1524739878.git.jstancek@redhat.com>
Hi!
> +#ifndef __XFRM_H__
> +#define __XFRM_H__
I tend to avoid double underscores in identifier names, since these are
reserved for libc, so I would have named this LAPI_XFRM_H__ or something
similar, but that is very minor.
Other than that acked.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-05-03 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 10:52 [LTP] [PATCH] cve-2017-16939: drop linux/xfrm.h include Jan Stancek
2018-04-26 12:46 ` Petr Vorel
2018-05-03 8:45 ` Cyril Hrubis [this message]
2018-05-03 9:45 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503084558.GD29568@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox