From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH ltp] fs/ext4: enhance logic of ext4_nsec_timestamps_test
Date: Thu, 3 May 2018 12:24:12 +0200 [thread overview]
Message-ID: <20180503102412.GB13151@rei> (raw)
In-Reply-To: <20180503082348.GB29568@rei>
Hi!
> > 2. Add "sleep 1" between mount and umount, to avoid umount failed due to
> > device busy (accessed by system service like systemd-udev)
>
> NACK to this.
>
> In a case that we need to wait for something like this we are supposed
> to retry in a loop with exponential backoff, which is usually faster
> than hardcoded sleep but also more robust.
>
> There is a in-flight patch for adding TST_RETRY_FUNC function to the
> shell library "[PATCH] tst_test.sh: achieve TST_RETRY_FUNC function in shell"
> which should make this really easy but we would have to add it to the
> old shell test library as well so that we can reuse it here.
And I remebered that we already solved this by adding tst_umount
function to the shell library. The systemd-udev is not first daemon to
probe newly mounted filesystem, we used to have this kind of problems
with gvfsd-trash as well.
So fixing this should be as easy as replacing the umount with tst_umount
function.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-05-03 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-29 0:02 [LTP] [PATCH ltp] fs/ext4: enhance logic of ext4_nsec_timestamps_test Yixin Zhang
2018-05-03 8:23 ` Cyril Hrubis
2018-05-03 10:24 ` Cyril Hrubis [this message]
2018-05-03 12:29 ` Petr Vorel
2018-05-03 13:25 ` Cyril Hrubis
2018-05-04 1:48 ` Zhang, Yixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503102412.GB13151@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox