public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC
@ 2018-05-04 12:53 Richard Palethorpe
  2018-05-08  3:31 ` Li Wang
  2018-05-09 12:33 ` Cyril Hrubis
  0 siblings, 2 replies; 3+ messages in thread
From: Richard Palethorpe @ 2018-05-04 12:53 UTC (permalink / raw)
  To: ltp

This message creates a lot of noise and uses extra resources on slower
machines. It also does not seem very useful.

Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
---

This may help debug test failures on ARM machines by reducing the amount of
noise.

 include/tst_common.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/include/tst_common.h b/include/tst_common.h
index d3d50eb19..27924766e 100644
--- a/include/tst_common.h
+++ b/include/tst_common.h
@@ -56,13 +56,10 @@
 		if (tst_ret_ == ERET)					\
 			break;						\
 		if (tst_delay_ < MAX_DELAY * 1000000) {			\
-			tst_res(TINFO,					\
-				#FUNC" returned %i, retrying"		\
-				" in %ius", tst_ret_, tst_delay_);	\
 			usleep(tst_delay_);				\
 			tst_delay_ *= 2;				\
 		} else {						\
-			tst_brk(TBROK, #FUNC" failed");			\
+			tst_brk(TBROK, #FUNC" timed out");		\
 		}							\
 	}								\
 	ERET;								\
-- 
2.16.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-09 12:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-04 12:53 [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC Richard Palethorpe
2018-05-08  3:31 ` Li Wang
2018-05-09 12:33 ` Cyril Hrubis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox